[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6607: Support internal cast for BuiltinScalarFunction::MakeArray

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #6607:
URL: https://github.com/apache/arrow-datafusion/pull/6607#discussion_r1227426508


##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -85,7 +87,18 @@ fn array_array(args: &[ArrayRef]) -> Result<ArrayRef> {
         ));
     }
 
-    let data_type = args[0].data_type();
+    let data_type = args

Review Comment:
   I think we are trying to avoid casting in the physical-exprs and instead want to cast in the `analyze` pass (so the rest of the optimizer passes see the correct types)
   
   I think this is the relevant code: 
   
   https://github.com/apache/arrow-datafusion/blob/071a2a6dfd43b3b225fce1af8838fa95c79f9ede/datafusion/optimizer/src/analyzer/type_coercion.rs#L389-L397
   
   Perhaps it needs to be taught about array arguments 🤔 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org