You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Alejandro Rivero (JIRA)" <ji...@apache.org> on 2008/04/09 16:32:28 UTC
[jira] Created: (SHINDIG-188) .getData() doesn't return an
Collection
.getData() doesn't return an Collection<activities>
---------------------------------------------------
Key: SHINDIG-188
URL: https://issues.apache.org/jira/browse/SHINDIG-188
Project: Shindig
Issue Type: Bug
Components: OpenSocial - Javascript
Reporter: Alejandro Rivero
In file features/opensocial-0.7/jsoncontainer.js
the function JsonContainer.prototype.newFetchActivitiesRequest
programs the request to return
return {'activities' : new opensocial.Collection(activities)};
and it should return
return new opensocial.Collection(activities)
according the API, or at least if the API is interpreted as in the example of FetchPeople.
Indeed, compare with JsonContainer.prototype.newFetchPeopleRequest = function(idSpec, opt_params) {
in the same file. This function is programmed to return
return new opensocial.Collection(people,...
and then the javascript code works as told in the Developer guide.
The only question about/against this correction is if there is already some production system supporting the undocumented result getData().activities. If it were so, the patch becomes more complex because it should support this legacy code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-188) .getData() doesn't return an
Collection
Posted by "Cassie Doll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Cassie Doll resolved SHINDIG-188.
---------------------------------
Resolution: Won't Fix
Assignee: Cassie Doll
Now that the opensocial 0.8 spec has been modified to get rid of the extra "activities" pointer we don't need to implement this half step. When Shindig supports opensocial 0.8 then this problem will go away.
> .getData() doesn't return an Collection<activities>
> ---------------------------------------------------
>
> Key: SHINDIG-188
> URL: https://issues.apache.org/jira/browse/SHINDIG-188
> Project: Shindig
> Issue Type: Bug
> Components: OpenSocial feature (Javascript)
> Reporter: Alejandro Rivero
> Assignee: Cassie Doll
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> In file features/opensocial-0.7/jsoncontainer.js
> the function JsonContainer.prototype.newFetchActivitiesRequest
> programs the request to return
> return {'activities' : new opensocial.Collection(activities)};
> and it should return
> return new opensocial.Collection(activities)
> according the API, or at least if the API is interpreted as in the example of FetchPeople.
> Indeed, compare with JsonContainer.prototype.newFetchPeopleRequest = function(idSpec, opt_params) {
> in the same file. This function is programmed to return
> return new opensocial.Collection(people,...
> and then the javascript code works as told in the Developer guide.
> The only question about/against this correction is if there is already some production system supporting the undocumented result getData().activities. If it were so, the patch becomes more complex because it should support this legacy code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-188) .getData() doesn't return an
Collection
Posted by "Alejandro Rivero (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587395#action_12587395 ]
Alejandro Rivero commented on SHINDIG-188:
------------------------------------------
I have been informed that it is not a bug; the actual way is the way dictated in the API specs; so it is really a question of the API and the corresponding issue has been then raised in the workgroup.
Still, the Json container could be patched to do both: answer to .getData().each() and to .getData().activities.each().
> .getData() doesn't return an Collection<activities>
> ---------------------------------------------------
>
> Key: SHINDIG-188
> URL: https://issues.apache.org/jira/browse/SHINDIG-188
> Project: Shindig
> Issue Type: Bug
> Components: OpenSocial - Javascript
> Reporter: Alejandro Rivero
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> In file features/opensocial-0.7/jsoncontainer.js
> the function JsonContainer.prototype.newFetchActivitiesRequest
> programs the request to return
> return {'activities' : new opensocial.Collection(activities)};
> and it should return
> return new opensocial.Collection(activities)
> according the API, or at least if the API is interpreted as in the example of FetchPeople.
> Indeed, compare with JsonContainer.prototype.newFetchPeopleRequest = function(idSpec, opt_params) {
> in the same file. This function is programmed to return
> return new opensocial.Collection(people,...
> and then the javascript code works as told in the Developer guide.
> The only question about/against this correction is if there is already some production system supporting the undocumented result getData().activities. If it were so, the patch becomes more complex because it should support this legacy code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.