You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/05 20:01:45 UTC

[GitHub] [doris] zhannngchen opened a new pull request, #13111: [Enhancement](load) remove load mem limit

zhannngchen opened a new pull request, #13111:
URL: https://github.com/apache/doris/pull/13111

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem summary
   
   #12716 removed the mem limit for single load task, in this PR I propose to remove the session variable load_mem_limit, to avoid confusing.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [ ] Yes
       - [ ] No
       - [ ] I don't know
   2. Has unit tests been added:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   3. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   4. Does it need to update dependencies:
       - [ ] Yes
       - [ ] No
   5. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [ ] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #13111: [Enhancement](load) remove load mem limit

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13111:
URL: https://github.com/apache/doris/pull/13111#issuecomment-1277295231

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #13111: [Enhancement](load) remove load mem limit

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13111:
URL: https://github.com/apache/doris/pull/13111#issuecomment-1277295164

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] xinyiZzz commented on pull request #13111: [Enhancement](load) remove load mem limit

Posted by GitBox <gi...@apache.org>.
xinyiZzz commented on PR #13111:
URL: https://github.com/apache/doris/pull/13111#issuecomment-1275516739

   1. Remove `LOAD_MEM_LIMIT` variable in `SessionVariable.java`
   2. Remove `get_load_mem_limit` and its usage in `runtime_state.cpp`
   3. Remove load mem limit in docs `variables.md`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] xinyiZzz merged pull request #13111: [Enhancement](load) remove load mem limit

Posted by GitBox <gi...@apache.org>.
xinyiZzz merged PR #13111:
URL: https://github.com/apache/doris/pull/13111


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] zhannngchen commented on pull request #13111: [Enhancement](load) remove load mem limit

Posted by GitBox <gi...@apache.org>.
zhannngchen commented on PR #13111:
URL: https://github.com/apache/doris/pull/13111#issuecomment-1275526565

   > * Remove `LOAD_MEM_LIMIT` variable in `SessionVariable.java`
   > * Remove `get_load_mem_limit` in `runtime_state.cpp` and use exec mem limit in `_query_mem_tracker->limit()` instead
   > * Remove load mem limit in docs `variables.md`
   
   Thanks for the check, 1 & 3 is addressed.
   For compatibility, load_mem_limit in thrift not removed, the value is set equal to exec_mem_limit in FE, so we should keep `get_load_mem_limit()` in `runtime_state.cpp`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org