You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/01/07 03:26:33 UTC
[GitHub] [rocketmq-client-go] codecov-io commented on issue #372: [ISSUE
#371]feat: clean extra code for internal packagec
codecov-io commented on issue #372: [ISSUE #371]feat: clean extra code for internal packagec
URL: https://github.com/apache/rocketmq-client-go/pull/372#issuecomment-571416907
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/372?src=pr&el=h1) Report
> Merging [#372](https://codecov.io/gh/apache/rocketmq-client-go/pull/372?src=pr&el=desc) into [native](https://codecov.io/gh/apache/rocketmq-client-go/commit/7f7a35d4934dc7b52472fd19d1a3eedb5c73d911?src=pr&el=desc) will **decrease** coverage by `0.89%`.
> The diff coverage is `12.5%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-go/pull/372/graphs/tree.svg?width=650&token=CiV9ofPkG3&height=150&src=pr)](https://codecov.io/gh/apache/rocketmq-client-go/pull/372?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## native #372 +/- ##
=========================================
- Coverage 26.27% 25.38% -0.9%
=========================================
Files 47 47
Lines 5537 5448 -89
=========================================
- Hits 1455 1383 -72
+ Misses 3891 3875 -16
+ Partials 191 190 -1
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/372?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [internal/route.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/372/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcm91dGUuZ28=) | `9.81% <ø> (+0.21%)` | :arrow_up: |
| [internal/validators.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/372/diff?src=pr&el=tree#diff-aW50ZXJuYWwvdmFsaWRhdG9ycy5nbw==) | `0% <ø> (ø)` | :arrow_up: |
| [consumer/push\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/372/diff?src=pr&el=tree#diff-Y29uc3VtZXIvcHVzaF9jb25zdW1lci5nbw==) | `13.28% <0%> (-0.02%)` | :arrow_down: |
| [internal/mock\_client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/372/diff?src=pr&el=tree#diff-aW50ZXJuYWwvbW9ja19jbGllbnQuZ28=) | `0% <0%> (ø)` | :arrow_up: |
| [internal/client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/372/diff?src=pr&el=tree#diff-aW50ZXJuYWwvY2xpZW50Lmdv) | `0.24% <0%> (ø)` | :arrow_up: |
| [producer/producer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/372/diff?src=pr&el=tree#diff-cHJvZHVjZXIvcHJvZHVjZXIuZ28=) | `30.12% <100%> (+0.21%)` | :arrow_up: |
| [internal/remote/remote\_client.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/372/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcmVtb3RlL3JlbW90ZV9jbGllbnQuZ28=) | `47.59% <0%> (-3.21%)` | :arrow_down: |
| [consumer/statistics.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/372/diff?src=pr&el=tree#diff-Y29uc3VtZXIvc3RhdGlzdGljcy5nbw==) | `63.66% <0%> (-1.64%)` | :arrow_down: |
| [internal/remote/future.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/372/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcmVtb3RlL2Z1dHVyZS5nbw==) | `100% <0%> (ø)` | :arrow_up: |
| [internal/utils/string.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/372/diff?src=pr&el=tree#diff-aW50ZXJuYWwvdXRpbHMvc3RyaW5nLmdv) | `0% <0%> (ø)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/rocketmq-client-go/pull/372/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/372?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/372?src=pr&el=footer). Last update [7f7a35d...64eb019](https://codecov.io/gh/apache/rocketmq-client-go/pull/372?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services