You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by th...@apache.org on 2013/10/29 21:40:30 UTC
[2/4] git commit: Fixed a typo.
Fixed a typo.
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/534d67cf
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/534d67cf
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/534d67cf
Branch: refs/heads/master
Commit: 534d67cf1163e142b0356779ea2d8d155a3bf95e
Parents: e6ec2f2
Author: Thiago H. de Paula Figueiredo <th...@apache.org>
Authored: Tue Oct 29 18:11:10 2013 -0200
Committer: Thiago H. de Paula Figueiredo <th...@apache.org>
Committed: Tue Oct 29 18:11:10 2013 -0200
----------------------------------------------------------------------
.../META-INF/modules/t5/core/console.coffee | 88 ++++++++++----------
1 file changed, 43 insertions(+), 45 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/534d67cf/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee
index ca44573..3962f8a 100644
--- a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee
+++ b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee
@@ -58,69 +58,67 @@ define ["./dom", "underscore", "./bootstrap"],
# console as needed.
display = (className, message) ->
- dom.withReflowEventsDisabled ->
-
- unless floatingConsole
- floatingConsole = dom.create
- class: "tapestry-console",
- """
- <div class="message-container"></div>
- <div class="row">
- <div class="btn-group btn-group-sm col-md-4">
- #{button "clear", "remove", "Clear Console"}
- #{button "enable", "play", "Enable Console"}
- #{button "disable", "pause", "Disable Console"}
- </div>
- <div class="col-md-8">
- <input class="form-control" size="40" placeholder="Filter console content">
- </div>
+ unless floatingConsole
+ floatingConsole = dom.create
+ class: "tapestry-console",
+ """
+ <div class="message-container"></div>
+ <div class="row">
+ <div class="btn-group btn-group-sm col-md-4">
+ #{button "clear", "remove", "Clear Console"}
+ #{button "enable", "play", "Enable Console"}
+ #{button "disable", "pause", "Disable Console"}
</div>
- """
+ <div class="col-md-8">
+ <input class="form-control" size="40" placeholder="Filter console content">
+ </div>
+ </div>
+ """
- dom.body.prepend floatingConsole
+ dom.body.prepend floatingConsole
- # Basically, any non-blank value will enable the floating console. In addition, the special
- # value "invisible" will enable it but then hide it ... this is useful in tests, since
- # the console output is captured in the markup, but the visible console can have unwanted interactions
- # (such as obscuring elements that make them unclickable).
- if consoleAttribute is "invisible"
- floatingConsole.hide()
+ # Basically, any non-blank value will enable the floating console. In addition, the special
+ # value "invisible" will enable it but then hide it ... this is useful in tests, since
+ # the console output is captured in the markup, but the visible console can have unwanted interactions
+ # (such as obscuring elements that make them unclickable).
+ if consoleAttribute is "invisible"
+ floatingConsole.hide()
- messages = floatingConsole.findFirst ".message-container"
+ messages = floatingConsole.findFirst ".message-container"
- floatingConsole.findFirst("[data-action=enable]").attribute "disabled", true
+ floatingConsole.findFirst("[data-action=enable]").attribute "disabled", true
- floatingConsole.on "click", "[data-action=clear]", ->
- floatingConsole.hide()
- messages.update ""
+ floatingConsole.on "click", "[data-action=clear]", ->
+ floatingConsole.hide()
+ messages.update ""
- floatingConsole.on "click", "[data-action=disable]", ->
+ floatingConsole.on "click", "[data-action=disable]", ->
- @attribute "disabled", true
- floatingConsole.findFirst("[data-action=enable]").attribute "disabled", false
+ @attribute "disabled", true
+ floatingConsole.findFirst("[data-action=enable]").attribute "disabled", false
- messages.hide()
+ messages.hide()
- return false
+ return false
- floatingConsole.on "click", "[data-action=enable]", ->
+ floatingConsole.on "click", "[data-action=enable]", ->
- @attribute "disabled", true
- floatingConsole.findFirst("[data-action=disable]").attribute "disabled", false
+ @attribute "disabled", true
+ floatingConsole.findFirst("[data-action=disable]").attribute "disabled", false
- messages.show()
+ messages.show()
- return false
+ return false
- floatingConsole.on "change keyup", "input", ->
- updateFilter @value()
+ floatingConsole.on "change keyup", "input", ->
+ updateFilter @value()
- for e in messages.children()
- visible = filter e
+ for e in messages.children()
+ visible = filter e
- e[if visible then "show" else "hide"]()
+ e[if visible then "show" else "hide"]()
- return false
+ return false
div = dom.create
class: className,
Re: [2/4] git commit: Fixed a typo.
Posted by Thiago H de Paula Figueiredo <th...@gmail.com>.
I'm sorry guys, I got some Eclipse and Git troubles and ended up doing two
commits that shouldn't have happened. Argh.
On Tue, 29 Oct 2013 18:40:30 -0200, <th...@apache.org> wrote:
> Fixed a typo.
>
> Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
> Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/534d67cf
> Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/534d67cf
> Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/534d67cf
>
> Branch: refs/heads/master
> Commit: 534d67cf1163e142b0356779ea2d8d155a3bf95e
> Parents: e6ec2f2
> Author: Thiago H. de Paula Figueiredo <th...@apache.org>
> Authored: Tue Oct 29 18:11:10 2013 -0200
> Committer: Thiago H. de Paula Figueiredo <th...@apache.org>
> Committed: Tue Oct 29 18:11:10 2013 -0200
>
> ----------------------------------------------------------------------
> .../META-INF/modules/t5/core/console.coffee | 88
> ++++++++++----------
> 1 file changed, 43 insertions(+), 45 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/534d67cf/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee
> ----------------------------------------------------------------------
> diff --git
> a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee
> b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee
> index ca44573..3962f8a 100644
> ---
> a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee
> +++
> b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee
> @@ -58,69 +58,67 @@ define ["./dom", "underscore", "./bootstrap"],
> # console as needed.
> display = (className, message) ->
> - dom.withReflowEventsDisabled ->
> -
> - unless floatingConsole
> - floatingConsole = dom.create
> - class: "tapestry-console",
> - """
> - <div class="message-container"></div>
> - <div class="row">
> - <div class="btn-group btn-group-sm col-md-4">
> - #{button "clear", "remove", "Clear Console"}
> - #{button "enable", "play", "Enable Console"}
> - #{button "disable", "pause", "Disable Console"}
> - </div>
> - <div class="col-md-8">
> - <input class="form-control" size="40"
> placeholder="Filter console content">
> - </div>
> + unless floatingConsole
> + floatingConsole = dom.create
> + class: "tapestry-console",
> + """
> + <div class="message-container"></div>
> + <div class="row">
> + <div class="btn-group btn-group-sm col-md-4">
> + #{button "clear", "remove", "Clear Console"}
> + #{button "enable", "play", "Enable Console"}
> + #{button "disable", "pause", "Disable Console"}
> </div>
> - """
> + <div class="col-md-8">
> + <input class="form-control" size="40"
> placeholder="Filter console content">
> + </div>
> + </div>
> + """
> - dom.body.prepend floatingConsole
> + dom.body.prepend floatingConsole
> - # Basically, any non-blank value will enable the floating
> console. In addition, the special
> - # value "invisible" will enable it but then hide it ... this
> is useful in tests, since
> - # the console output is captured in the markup, but the
> visible console can have unwanted interactions
> - # (such as obscuring elements that make them unclickable).
> - if consoleAttribute is "invisible"
> - floatingConsole.hide()
> + # Basically, any non-blank value will enable the floating
> console. In addition, the special
> + # value "invisible" will enable it but then hide it ... this is
> useful in tests, since
> + # the console output is captured in the markup, but the visible
> console can have unwanted interactions
> + # (such as obscuring elements that make them unclickable).
> + if consoleAttribute is "invisible"
> + floatingConsole.hide()
> - messages = floatingConsole.findFirst ".message-container"
> + messages = floatingConsole.findFirst ".message-container"
> - floatingConsole.findFirst("[data-action=enable]").attribute
> "disabled", true
> + floatingConsole.findFirst("[data-action=enable]").attribute
> "disabled", true
> - floatingConsole.on "click", "[data-action=clear]", ->
> - floatingConsole.hide()
> - messages.update ""
> + floatingConsole.on "click", "[data-action=clear]", ->
> + floatingConsole.hide()
> + messages.update ""
> - floatingConsole.on "click", "[data-action=disable]", ->
> + floatingConsole.on "click", "[data-action=disable]", ->
> - @attribute "disabled", true
> - floatingConsole.findFirst("[data-action=enable]").attribute
> "disabled", false
> + @attribute "disabled", true
> + floatingConsole.findFirst("[data-action=enable]").attribute
> "disabled", false
> - messages.hide()
> + messages.hide()
> - return false
> + return false
> - floatingConsole.on "click", "[data-action=enable]", ->
> + floatingConsole.on "click", "[data-action=enable]", ->
> - @attribute "disabled", true
> -
> floatingConsole.findFirst("[data-action=disable]").attribute "disabled",
> false
> + @attribute "disabled", true
> + floatingConsole.findFirst("[data-action=disable]").attribute
> "disabled", false
> - messages.show()
> + messages.show()
> - return false
> + return false
> - floatingConsole.on "change keyup", "input", ->
> - updateFilter @value()
> + floatingConsole.on "change keyup", "input", ->
> + updateFilter @value()
> - for e in messages.children()
> - visible = filter e
> + for e in messages.children()
> + visible = filter e
> - e[if visible then "show" else "hide"]()
> + e[if visible then "show" else "hide"]()
> - return false
> + return false
> div = dom.create
> class: className,
>
--
Thiago H. de Paula Figueiredo
Tapestry, Java and Hibernate consultant and developer
http://machina.com.br
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org