You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by en...@apache.org on 2015/12/22 11:57:28 UTC

[1/4] hbase git commit: HBASE-14977 ChoreService.shutdown may result in ConcurrentModificationException - ADDENDUM to fix extra concurrency issues

Repository: hbase
Updated Branches:
  refs/heads/branch-1 cf059e54b -> 1b66f474b
  refs/heads/branch-1.1 f64cf4d8c -> 73b4d377b
  refs/heads/branch-1.2 25d412d4e -> 4f3c969df
  refs/heads/master 6e2c5d216 -> 95a13b51e


HBASE-14977 ChoreService.shutdown may result in ConcurrentModificationException - ADDENDUM to fix extra concurrency issues


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/95a13b51
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/95a13b51
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/95a13b51

Branch: refs/heads/master
Commit: 95a13b51ee052eb73882682e8f009bfa1e914866
Parents: 6e2c5d2
Author: Enis Soztutar <en...@apache.org>
Authored: Tue Dec 22 02:04:09 2015 -0800
Committer: Enis Soztutar <en...@apache.org>
Committed: Tue Dec 22 02:04:09 2015 -0800

----------------------------------------------------------------------
 .../java/org/apache/hadoop/hbase/ScheduledChore.java    | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/95a13b51/hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java
----------------------------------------------------------------------
diff --git a/hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java b/hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java
index 538b390..dd98d26 100644
--- a/hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java
+++ b/hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java
@@ -228,7 +228,7 @@ public abstract class ScheduledChore implements Runnable {
         && getTimeBetweenRuns() > getMaximumAllowedTimeBetweenRuns();
   }
 
-  private synchronized double getMaximumAllowedTimeBetweenRuns() {
+  private double getMaximumAllowedTimeBetweenRuns() {
     // Threshold used to determine if the Chore's current run started too late
     return 1.5 * period;
   }
@@ -268,23 +268,23 @@ public abstract class ScheduledChore implements Runnable {
     choreServicer = null;
   }
 
-  public synchronized String getName() {
+  public String getName() {
     return name;
   }
 
-  public synchronized Stoppable getStopper() {
+  public Stoppable getStopper() {
     return stopper;
   }
 
-  public synchronized int getPeriod() {
+  public int getPeriod() {
     return period;
   }
 
-  public synchronized long getInitialDelay() {
+  public long getInitialDelay() {
     return initialDelay;
   }
 
-  public final synchronized TimeUnit getTimeUnit() {
+  public TimeUnit getTimeUnit() {
     return timeUnit;
   }
 


[4/4] hbase git commit: HBASE-14977 ChoreService.shutdown may result in ConcurrentModificationException - ADDENDUM to fix extra concurrency issues

Posted by en...@apache.org.
HBASE-14977 ChoreService.shutdown may result in ConcurrentModificationException - ADDENDUM to fix extra concurrency issues


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/73b4d377
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/73b4d377
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/73b4d377

Branch: refs/heads/branch-1.1
Commit: 73b4d377b1076ea772536dbb71690e1ff77ed28c
Parents: f64cf4d
Author: Enis Soztutar <en...@apache.org>
Authored: Tue Dec 22 02:04:09 2015 -0800
Committer: Enis Soztutar <en...@apache.org>
Committed: Tue Dec 22 02:07:31 2015 -0800

----------------------------------------------------------------------
 .../java/org/apache/hadoop/hbase/ScheduledChore.java    | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/73b4d377/hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java
----------------------------------------------------------------------
diff --git a/hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java b/hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java
index 8670d60..3b0b3f7 100644
--- a/hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java
+++ b/hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java
@@ -228,7 +228,7 @@ public abstract class ScheduledChore implements Runnable {
         && getTimeBetweenRuns() > getMaximumAllowedTimeBetweenRuns();
   }
 
-  private synchronized double getMaximumAllowedTimeBetweenRuns() {
+  private double getMaximumAllowedTimeBetweenRuns() {
     // Threshold used to determine if the Chore's current run started too late
     return 1.5 * period;
   }
@@ -268,23 +268,23 @@ public abstract class ScheduledChore implements Runnable {
     choreServicer = null;
   }
 
-  public synchronized String getName() {
+  public String getName() {
     return name;
   }
 
-  public synchronized Stoppable getStopper() {
+  public Stoppable getStopper() {
     return stopper;
   }
 
-  public synchronized int getPeriod() {
+  public int getPeriod() {
     return period;
   }
 
-  public synchronized long getInitialDelay() {
+  public long getInitialDelay() {
     return initialDelay;
   }
 
-  public final synchronized TimeUnit getTimeUnit() {
+  public TimeUnit getTimeUnit() {
     return timeUnit;
   }
 


[3/4] hbase git commit: HBASE-14977 ChoreService.shutdown may result in ConcurrentModificationException - ADDENDUM to fix extra concurrency issues

Posted by en...@apache.org.
HBASE-14977 ChoreService.shutdown may result in ConcurrentModificationException - ADDENDUM to fix extra concurrency issues


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/4f3c969d
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/4f3c969d
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/4f3c969d

Branch: refs/heads/branch-1.2
Commit: 4f3c969dfcf3c9e3c020793cbca57c8a2ad1a4c2
Parents: 25d412d
Author: Enis Soztutar <en...@apache.org>
Authored: Tue Dec 22 02:04:09 2015 -0800
Committer: Enis Soztutar <en...@apache.org>
Committed: Tue Dec 22 02:05:59 2015 -0800

----------------------------------------------------------------------
 .../java/org/apache/hadoop/hbase/ScheduledChore.java    | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/4f3c969d/hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java
----------------------------------------------------------------------
diff --git a/hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java b/hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java
index 538b390..dd98d26 100644
--- a/hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java
+++ b/hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java
@@ -228,7 +228,7 @@ public abstract class ScheduledChore implements Runnable {
         && getTimeBetweenRuns() > getMaximumAllowedTimeBetweenRuns();
   }
 
-  private synchronized double getMaximumAllowedTimeBetweenRuns() {
+  private double getMaximumAllowedTimeBetweenRuns() {
     // Threshold used to determine if the Chore's current run started too late
     return 1.5 * period;
   }
@@ -268,23 +268,23 @@ public abstract class ScheduledChore implements Runnable {
     choreServicer = null;
   }
 
-  public synchronized String getName() {
+  public String getName() {
     return name;
   }
 
-  public synchronized Stoppable getStopper() {
+  public Stoppable getStopper() {
     return stopper;
   }
 
-  public synchronized int getPeriod() {
+  public int getPeriod() {
     return period;
   }
 
-  public synchronized long getInitialDelay() {
+  public long getInitialDelay() {
     return initialDelay;
   }
 
-  public final synchronized TimeUnit getTimeUnit() {
+  public TimeUnit getTimeUnit() {
     return timeUnit;
   }
 


[2/4] hbase git commit: HBASE-14977 ChoreService.shutdown may result in ConcurrentModificationException - ADDENDUM to fix extra concurrency issues

Posted by en...@apache.org.
HBASE-14977 ChoreService.shutdown may result in ConcurrentModificationException - ADDENDUM to fix extra concurrency issues


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/1b66f474
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/1b66f474
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/1b66f474

Branch: refs/heads/branch-1
Commit: 1b66f474b5fcc808251c4b6fd5d4ae028656e44d
Parents: cf059e5
Author: Enis Soztutar <en...@apache.org>
Authored: Tue Dec 22 02:04:09 2015 -0800
Committer: Enis Soztutar <en...@apache.org>
Committed: Tue Dec 22 02:04:32 2015 -0800

----------------------------------------------------------------------
 .../java/org/apache/hadoop/hbase/ScheduledChore.java    | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/1b66f474/hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java
----------------------------------------------------------------------
diff --git a/hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java b/hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java
index 538b390..dd98d26 100644
--- a/hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java
+++ b/hbase-common/src/main/java/org/apache/hadoop/hbase/ScheduledChore.java
@@ -228,7 +228,7 @@ public abstract class ScheduledChore implements Runnable {
         && getTimeBetweenRuns() > getMaximumAllowedTimeBetweenRuns();
   }
 
-  private synchronized double getMaximumAllowedTimeBetweenRuns() {
+  private double getMaximumAllowedTimeBetweenRuns() {
     // Threshold used to determine if the Chore's current run started too late
     return 1.5 * period;
   }
@@ -268,23 +268,23 @@ public abstract class ScheduledChore implements Runnable {
     choreServicer = null;
   }
 
-  public synchronized String getName() {
+  public String getName() {
     return name;
   }
 
-  public synchronized Stoppable getStopper() {
+  public Stoppable getStopper() {
     return stopper;
   }
 
-  public synchronized int getPeriod() {
+  public int getPeriod() {
     return period;
   }
 
-  public synchronized long getInitialDelay() {
+  public long getInitialDelay() {
     return initialDelay;
   }
 
-  public final synchronized TimeUnit getTimeUnit() {
+  public TimeUnit getTimeUnit() {
     return timeUnit;
   }