You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ms...@apache.org on 2020/11/15 23:36:44 UTC

svn commit: r1883463 - /pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/TestXMPWithDefinedSchemas.java

Author: msahyoun
Date: Sun Nov 15 23:36:44 2020
New Revision: 1883463

URL: http://svn.apache.org/viewvc?rev=1883463&view=rev
Log:
PDFBOX-5017: switch test to junit5; use parameterized test

Modified:
    pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/TestXMPWithDefinedSchemas.java

Modified: pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/TestXMPWithDefinedSchemas.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/TestXMPWithDefinedSchemas.java?rev=1883463&r1=1883462&r2=1883463&view=diff
==============================================================================
--- pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/TestXMPWithDefinedSchemas.java (original)
+++ pdfbox/trunk/xmpbox/src/test/java/org/apache/xmpbox/TestXMPWithDefinedSchemas.java Sun Nov 15 23:36:44 2020
@@ -22,48 +22,34 @@
 package org.apache.xmpbox;
 
 import java.io.InputStream;
-import java.util.ArrayList;
-import java.util.Collection;
-import java.util.List;
+import java.util.stream.Stream;
 
 import org.apache.xmpbox.xml.DomXmpParser;
-import org.junit.Test;
-import org.junit.runner.RunWith;
-import org.junit.runners.Parameterized;
-import org.junit.runners.Parameterized.Parameters;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.MethodSource;
 
-@RunWith(Parameterized.class)
-public class TestXMPWithDefinedSchemas
-{
-
-    @Parameters
-    public static Collection<Object[]> initializeParameters() throws Exception
-    {
-        List<Object[]> data = new ArrayList<>();
-        data.add(new Object[] { "/validxmp/override_ns.rdf" });
-        data.add(new Object[] { "/validxmp/ghost2.xmp" });
-        data.add(new Object[] { "/validxmp/history2.rdf" });
-        data.add(new Object[] { "/validxmp/Notepad++_A1b.xmp" });
-        data.add(new Object[] { "/validxmp/metadata.rdf" });
-        return data;
-    }
 
-    private final String path;
 
-    public TestXMPWithDefinedSchemas(String path)
+public class TestXMPWithDefinedSchemas
+{
+    public static Stream<String> initializeParameters() throws Exception
     {
-        this.path = path;
+        return Stream.of(
+            "/validxmp/override_ns.rdf",
+            "/validxmp/ghost2.xmp",
+            "/validxmp/history2.rdf",
+            "/validxmp/Notepad++_A1b.xmp",
+            "/validxmp/metadata.rdf"
+        );
     }
 
-    @Test
-    public void main() throws Exception
+    @ParameterizedTest
+    @MethodSource("initializeParameters")
+    public void main(String path) throws Exception
     {
-
         InputStream is = this.getClass().getResourceAsStream(path);
 
         DomXmpParser builder = new DomXmpParser();
         XMPMetadata rxmp = builder.parse(is);
-
     }
-
 }