You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/02 12:13:04 UTC

[GitHub] [airflow] msumit commented on pull request #19155: Resurrect python openapi client generator

msumit commented on pull request #19155:
URL: https://github.com/apache/airflow/pull/19155#issuecomment-957415951


   > Instead of `|| true`, we should check `$?` and only show the message on failures.
   
   Given that we are deleting lots of folders before generating code & then running `pre-commit`, so it's always going to return with a non-zero exit code. Thus no point in adding a if check, just to display the message, which anyway always going to be displayed. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org