You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/05/27 12:00:00 UTC

[GitHub] [rocketmq] vongosling commented on a change in pull request #1985: [ISSUE #1976]System topic should add permission checking globally

vongosling commented on a change in pull request #1985:
URL: https://github.com/apache/rocketmq/pull/1985#discussion_r431062292



##########
File path: broker/src/main/java/org/apache/rocketmq/broker/topic/TopicConfigManager.java
##########
@@ -124,6 +124,14 @@ public TopicConfigManager(BrokerController brokerController) {
             topicConfig.setWriteQueueNums(1);
             this.topicConfigTable.put(topicConfig.getTopicName(), topicConfig);
         }
+        {
+            String topic = MixAll.SCHEDULE_TOPIC;
+            TopicConfig topicConfig = new TopicConfig(topic);

Review comment:
       system topic should be a List, also, we could judge it from the naming, a prefix is a good way.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org