You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/11 15:29:56 UTC

[GitHub] [flink] rkhachatryan opened a new pull request #19063: [FLINK-26615][tests] Fix timings in BatchingStateChangeUploadSchedulerTest.testUploadTimeout

rkhachatryan opened a new pull request #19063:
URL: https://github.com/apache/flink/pull/19063


   ## What is the purpose of the change
   
   `BatchingStateChangeUploadSchedulerTest.testRetryOnTimeout` might fail if all attempts time out before 
   the check is performed and the underlying uploader is unblocked.
   
   This change increases the difference between those timings, so that the check is much faster.  
   
   ## Verifying this change
   
   This change is a trivial rework without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] curcur edited a comment on pull request #19063: [FLINK-26615][tests] Fix timings in BatchingStateChangeUploadSchedulerTest.testUploadTimeout

Posted by GitBox <gi...@apache.org>.
curcur edited a comment on pull request #19063:
URL: https://github.com/apache/flink/pull/19063#issuecomment-1079861676


   @rkhachatryan LGTM.
   
   Azure have some failures:
   
   "Mar 11 17:30:57 [ERROR] ChangelogPeriodicMaterializationITCase.testFailedMaterialization
   Mar 11 17:30:57 [ERROR]   Run 1: Recovery is suppressed by FixedDelayRestartBackoffTimeStrategy(maxNumberRestartAttempts=1, backoffTimeMS=0)"
   
   But seem not to relevant to this change.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] curcur commented on pull request #19063: [FLINK-26615][tests] Fix timings in BatchingStateChangeUploadSchedulerTest.testUploadTimeout

Posted by GitBox <gi...@apache.org>.
curcur commented on pull request #19063:
URL: https://github.com/apache/flink/pull/19063#issuecomment-1079861676


   LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19063: [FLINK-26615][tests] Fix timings in BatchingStateChangeUploadSchedulerTest.testUploadTimeout

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19063:
URL: https://github.com/apache/flink/pull/19063#issuecomment-1065224961


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "513f24c270f98f59acfdf9810c130f4b0b819612",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32930",
       "triggerID" : "513f24c270f98f59acfdf9810c130f4b0b819612",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 513f24c270f98f59acfdf9810c130f4b0b819612 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32930) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19063: [FLINK-26615][tests] Fix timings in BatchingStateChangeUploadSchedulerTest.testUploadTimeout

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #19063:
URL: https://github.com/apache/flink/pull/19063#issuecomment-1065224961


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "513f24c270f98f59acfdf9810c130f4b0b819612",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "513f24c270f98f59acfdf9810c130f4b0b819612",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 513f24c270f98f59acfdf9810c130f4b0b819612 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19063: [FLINK-26615][tests] Fix timings in BatchingStateChangeUploadSchedulerTest.testUploadTimeout

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19063:
URL: https://github.com/apache/flink/pull/19063#issuecomment-1065224961


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "513f24c270f98f59acfdf9810c130f4b0b819612",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32930",
       "triggerID" : "513f24c270f98f59acfdf9810c130f4b0b819612",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 513f24c270f98f59acfdf9810c130f4b0b819612 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32930) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rkhachatryan commented on pull request #19063: [FLINK-26615][tests] Fix timings in BatchingStateChangeUploadSchedulerTest.testUploadTimeout

Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #19063:
URL: https://github.com/apache/flink/pull/19063#issuecomment-1079904787


   Thanks for the review @curcur.
   Private branch [built successfully](https://dev.azure.com/khachatryanroman/flink/_build/results?buildId=1474&view=results), merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rkhachatryan merged pull request #19063: [FLINK-26615][tests] Fix timings in BatchingStateChangeUploadSchedulerTest.testUploadTimeout

Posted by GitBox <gi...@apache.org>.
rkhachatryan merged pull request #19063:
URL: https://github.com/apache/flink/pull/19063


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org