[GitHub] [incubator-sdap-in-situ-data-services] briansaildrone commented on a diff in pull request #3: Action Items [5/27/2022]

[GitBox <gi...@apache.org>]

briansaildrone commented on code in PR #3:
URL: https://github.com/apache/incubator-sdap-in-situ-data-services/pull/3#discussion_r887334513


##########
k8s_spark/parquet.spark.helm/templates/deployment.yaml:
##########
@@ -57,8 +57,10 @@ spec:
             {{- end }}
             - name: parquet_file_name
               value: {{ .Values.flask_env.parquet_file_name }}
+            {{- if ( index .Values "bitnami-spark" "enabled" ) }}
             - name: master_spark_url
-              value: {{ .Values.flask_env.master_spark_url }}
+              value: spark://{{ .Release.Name }}-bitnami-spark-master-0.{{ .Release.Name }}-bitnami-spark-headless:7077

Review Comment:
   When connecting to a service within the same namespace, specifying the namespace is optional within the FQDN, which makes things much simpler here.
   https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#namespaces-of-services



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org