You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by bhuvnesh chaudhary <bc...@pivotal.io> on 2016/04/21 21:12:49 UTC

Review Request 46509: Remove performing service check during "Remove Standby Wizard"

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46509/
-----------------------------------------------------------

Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr Diachenko.


Bugs: AMBARI-16024
    https://issues.apache.org/jira/browse/AMBARI-16024


Repository: ambari


Description
-------

Users will need to remove the HAWQ Standby Master using "Remove Standby Wizard" after enabling HDFS HA.
So the service check may fail during the wizard as the HAWQ catalog might be still pointing to the old filespace.


Diffs
-----

  ambari-web/app/controllers/main/admin/highAvailability/hawq/removeStandby/step3_controller.js 5bcf34f 

Diff: https://reviews.apache.org/r/46509/diff/


Testing
-------

yes.
~/github/ambari-vagrant/centos6.4/ambari/ambari-server/src/test/python/stacks/2.3/HAWQ ~/github/ambari-vagrant/centos6.4/ambari
test_hawq_master_critical (test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_segment_critical (test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_standby_critical (test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) ... ok
test_missing_configs (test_alert_component_status.TestAlertComponentStatus) ... ok
test_exception_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No handlers could be found for logger "ambari_alerts"
ok
test_missing_configs (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_missing_slave_file (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_successful_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_empty_db_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_registration_status_plural (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
test_install_default (test_hawqmaster.TestHawqMaster) ... ok
test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-04-21 12:15:00,349 - Skipping ssh key exchange with HAWQ hosts as hawq_ssh_exkeys is either set to false or is not available in hawq-env.xml
ok
test_stop_default (test_hawqmaster.TestHawqMaster) ... ok
test_configure_default (test_hawqsegment.TestHawqSegment) ... ok
test_install_default (test_hawqsegment.TestHawqSegment) ... ok
test_start_default (test_hawqsegment.TestHawqSegment) ... ok
test_stop_default (test_hawqsegment.TestHawqSegment) ... ok
test_configure_default (test_hawqstandby.TestHawqStandby) ... ok
test_install_default (test_hawqstandby.TestHawqStandby) ... ok
test_start_default (test_hawqstandby.TestHawqStandby) ... ok
test_stop_default (test_hawqstandby.TestHawqStandby) ... ok
test_generate_hawq_process_status_cmd (test_utils.TestUtils) ... ok

----------------------------------------------------------------------
Ran 35 tests in 0.178s

OK


Thanks,

bhuvnesh chaudhary

Re: Review Request 46509: Remove performing service check during "Remove Standby Wizard"

Posted by Alexander Denissov <ad...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46509/#review130162
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Denissov


On April 21, 2016, 11:01 p.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46509/
> -----------------------------------------------------------
> 
> (Updated April 21, 2016, 11:01 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr Diachenko.
> 
> 
> Bugs: AMBARI-16024
>     https://issues.apache.org/jira/browse/AMBARI-16024
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Users will need to remove the HAWQ Standby Master using "Remove Standby Wizard" after enabling HDFS HA.
> So the service check may fail during the wizard as the HAWQ catalog might be still pointing to the old filespace.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/admin/highAvailability/hawq/removeStandby/step3_controller.js 5bcf34f 
> 
> Diff: https://reviews.apache.org/r/46509/diff/
> 
> 
> Testing
> -------
> 
> yes.
>   25660 tests complete (29 seconds)
>   154 tests pending
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 46.511 s
> [INFO] Finished at: 2016-04-21T16:03:11-07:00
> [INFO] Final Memory: 14M/331M
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Re: Review Request 46509: Remove performing service check during "Remove Standby Wizard"

Posted by bhuvnesh chaudhary <bc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46509/
-----------------------------------------------------------

(Updated April 21, 2016, 11:01 p.m.)


Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr Diachenko.


Bugs: AMBARI-16024
    https://issues.apache.org/jira/browse/AMBARI-16024


Repository: ambari


Description
-------

Users will need to remove the HAWQ Standby Master using "Remove Standby Wizard" after enabling HDFS HA.
So the service check may fail during the wizard as the HAWQ catalog might be still pointing to the old filespace.


Diffs
-----

  ambari-web/app/controllers/main/admin/highAvailability/hawq/removeStandby/step3_controller.js 5bcf34f 

Diff: https://reviews.apache.org/r/46509/diff/


Testing (updated)
-------

yes.
  25660 tests complete (29 seconds)
  154 tests pending
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 46.511 s
[INFO] Finished at: 2016-04-21T16:03:11-07:00
[INFO] Final Memory: 14M/331M


Thanks,

bhuvnesh chaudhary

Re: Review Request 46509: Remove performing service check during "Remove Standby Wizard"

Posted by bhuvnesh chaudhary <bc...@pivotal.io>.

> On April 21, 2016, 8:23 p.m., Matt wrote:
> > Better run unit tests on ambari-web instead of stacks/HAWQ

thats right


- bhuvnesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46509/#review129946
-----------------------------------------------------------


On April 21, 2016, 7:12 p.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46509/
> -----------------------------------------------------------
> 
> (Updated April 21, 2016, 7:12 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr Diachenko.
> 
> 
> Bugs: AMBARI-16024
>     https://issues.apache.org/jira/browse/AMBARI-16024
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Users will need to remove the HAWQ Standby Master using "Remove Standby Wizard" after enabling HDFS HA.
> So the service check may fail during the wizard as the HAWQ catalog might be still pointing to the old filespace.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/admin/highAvailability/hawq/removeStandby/step3_controller.js 5bcf34f 
> 
> Diff: https://reviews.apache.org/r/46509/diff/
> 
> 
> Testing
> -------
> 
> yes.
> ~/github/ambari-vagrant/centos6.4/ambari/ambari-server/src/test/python/stacks/2.3/HAWQ ~/github/ambari-vagrant/centos6.4/ambari
> test_hawq_master_critical (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_critical (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_critical (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_exception_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-04-21 12:15:00,349 - Skipping ssh key exchange with HAWQ hosts as hawq_ssh_exkeys is either set to false or is not available in hawq-env.xml
> ok
> test_stop_default (test_hawqmaster.TestHawqMaster) ... ok
> test_configure_default (test_hawqsegment.TestHawqSegment) ... ok
> test_install_default (test_hawqsegment.TestHawqSegment) ... ok
> test_start_default (test_hawqsegment.TestHawqSegment) ... ok
> test_stop_default (test_hawqsegment.TestHawqSegment) ... ok
> test_configure_default (test_hawqstandby.TestHawqStandby) ... ok
> test_install_default (test_hawqstandby.TestHawqStandby) ... ok
> test_start_default (test_hawqstandby.TestHawqStandby) ... ok
> test_stop_default (test_hawqstandby.TestHawqStandby) ... ok
> test_generate_hawq_process_status_cmd (test_utils.TestUtils) ... ok
> 
> ----------------------------------------------------------------------
> Ran 35 tests in 0.178s
> 
> OK
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Re: Review Request 46509: Remove performing service check during "Remove Standby Wizard"

Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46509/#review129946
-----------------------------------------------------------


Ship it!




Better run unit tests on ambari-web instead of stacks/HAWQ

- Matt


On April 21, 2016, 12:12 p.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46509/
> -----------------------------------------------------------
> 
> (Updated April 21, 2016, 12:12 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr Diachenko.
> 
> 
> Bugs: AMBARI-16024
>     https://issues.apache.org/jira/browse/AMBARI-16024
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Users will need to remove the HAWQ Standby Master using "Remove Standby Wizard" after enabling HDFS HA.
> So the service check may fail during the wizard as the HAWQ catalog might be still pointing to the old filespace.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/admin/highAvailability/hawq/removeStandby/step3_controller.js 5bcf34f 
> 
> Diff: https://reviews.apache.org/r/46509/diff/
> 
> 
> Testing
> -------
> 
> yes.
> ~/github/ambari-vagrant/centos6.4/ambari/ambari-server/src/test/python/stacks/2.3/HAWQ ~/github/ambari-vagrant/centos6.4/ambari
> test_hawq_master_critical (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_critical (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_critical (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_exception_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_start_default (test_hawqmaster.TestHawqMaster) ... 2016-04-21 12:15:00,349 - Skipping ssh key exchange with HAWQ hosts as hawq_ssh_exkeys is either set to false or is not available in hawq-env.xml
> ok
> test_stop_default (test_hawqmaster.TestHawqMaster) ... ok
> test_configure_default (test_hawqsegment.TestHawqSegment) ... ok
> test_install_default (test_hawqsegment.TestHawqSegment) ... ok
> test_start_default (test_hawqsegment.TestHawqSegment) ... ok
> test_stop_default (test_hawqsegment.TestHawqSegment) ... ok
> test_configure_default (test_hawqstandby.TestHawqStandby) ... ok
> test_install_default (test_hawqstandby.TestHawqStandby) ... ok
> test_start_default (test_hawqstandby.TestHawqStandby) ... ok
> test_stop_default (test_hawqstandby.TestHawqStandby) ... ok
> test_generate_hawq_process_status_cmd (test_utils.TestUtils) ... ok
> 
> ----------------------------------------------------------------------
> Ran 35 tests in 0.178s
> 
> OK
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>