You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/13 10:34:58 UTC
[GitHub] [arrow] nevi-me opened a new pull request #8905: ARROW-10893: [Rust] [DataFusion] More clippy lints
nevi-me opened a new pull request #8905:
URL: https://github.com/apache/arrow/pull/8905
This addresses more clippy lints, especially the ones that `cargo clippy --fix -Z unstable-options --allow-dirty` can address
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me commented on pull request #8905: ARROW-10893: [Rust] [DataFusion] More clippy lints
Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #8905:
URL: https://github.com/apache/arrow/pull/8905#issuecomment-743985708
@Dandandan making your work a bit harder by taking out the lints that clippy can mostly fix automatically :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #8905: ARROW-10893: [Rust] [DataFusion] More clippy lints
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #8905:
URL: https://github.com/apache/arrow/pull/8905#issuecomment-743986440
# [Codecov](https://codecov.io/gh/apache/arrow/pull/8905?src=pr&el=h1) Report
> Merging [#8905](https://codecov.io/gh/apache/arrow/pull/8905?src=pr&el=desc) (884458e) into [master](https://codecov.io/gh/apache/arrow/commit/fcad0b909b769b4107cea943d19dcaefa1888cf2?el=desc) (fcad0b9) will **increase** coverage by `0.02%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/arrow/pull/8905?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8905 +/- ##
==========================================
+ Coverage 76.77% 76.79% +0.02%
==========================================
Files 181 181
Lines 41011 40996 -15
==========================================
- Hits 31485 31484 -1
+ Misses 9526 9512 -14
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/8905?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/datafusion/src/datasource/memory.rs](https://codecov.io/gh/apache/arrow/pull/8905/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9kYXRhc291cmNlL21lbW9yeS5ycw==) | `0.00% <ø> (ø)` | |
| [rust/datafusion/src/execution/context.rs](https://codecov.io/gh/apache/arrow/pull/8905/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9leGVjdXRpb24vY29udGV4dC5ycw==) | `0.00% <0.00%> (ø)` | |
| [rust/datafusion/src/logical\_plan/builder.rs](https://codecov.io/gh/apache/arrow/pull/8905/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9sb2dpY2FsX3BsYW4vYnVpbGRlci5ycw==) | `0.00% <ø> (ø)` | |
| [rust/datafusion/src/logical\_plan/dfschema.rs](https://codecov.io/gh/apache/arrow/pull/8905/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9sb2dpY2FsX3BsYW4vZGZzY2hlbWEucnM=) | `0.00% <0.00%> (ø)` | |
| [rust/datafusion/src/optimizer/filter\_push\_down.rs](https://codecov.io/gh/apache/arrow/pull/8905/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9vcHRpbWl6ZXIvZmlsdGVyX3B1c2hfZG93bi5ycw==) | `0.00% <0.00%> (ø)` | |
| [...t/datafusion/src/optimizer/projection\_push\_down.rs](https://codecov.io/gh/apache/arrow/pull/8905/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9vcHRpbWl6ZXIvcHJvamVjdGlvbl9wdXNoX2Rvd24ucnM=) | `0.00% <0.00%> (ø)` | |
| [rust/datafusion/src/optimizer/utils.rs](https://codecov.io/gh/apache/arrow/pull/8905/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9vcHRpbWl6ZXIvdXRpbHMucnM=) | `0.00% <0.00%> (ø)` | |
| [rust/datafusion/src/physical\_plan/common.rs](https://codecov.io/gh/apache/arrow/pull/8905/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2NvbW1vbi5ycw==) | `0.00% <ø> (ø)` | |
| [rust/datafusion/src/physical\_plan/csv.rs](https://codecov.io/gh/apache/arrow/pull/8905/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2Nzdi5ycw==) | `0.00% <0.00%> (ø)` | |
| [...tafusion/src/physical\_plan/datetime\_expressions.rs](https://codecov.io/gh/apache/arrow/pull/8905/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2RhdGV0aW1lX2V4cHJlc3Npb25zLnJz) | `0.00% <ø> (ø)` | |
| ... and [11 more](https://codecov.io/gh/apache/arrow/pull/8905/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/8905?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/8905?src=pr&el=footer). Last update [fcad0b9...884458e](https://codecov.io/gh/apache/arrow/pull/8905?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #8905: ARROW-10893: [Rust] [DataFusion] More clippy lints
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #8905:
URL: https://github.com/apache/arrow/pull/8905
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Dandandan commented on pull request #8905: ARROW-10893: [Rust] [DataFusion] More clippy lints
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #8905:
URL: https://github.com/apache/arrow/pull/8905#issuecomment-743988394
Ah... just learned a new thing, that clippy (not only the lints in rustc) can be applied automatically using that command. Cool!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8905: ARROW-10893: [Rust] [DataFusion] More clippy lints
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8905:
URL: https://github.com/apache/arrow/pull/8905#issuecomment-743987918
https://issues.apache.org/jira/browse/ARROW-10893
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Dandandan commented on pull request #8905: ARROW-10893: [Rust] [DataFusion] More clippy lints
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #8905:
URL: https://github.com/apache/arrow/pull/8905#issuecomment-743988899
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org