Re: [PR] #1107 Implementation of `OSV-scanner` with `gh-action` (streampipes)

["bossenti (via GitHub)" <gi...@apache.org>]

bossenti commented on code in PR #1438:
URL: https://github.com/apache/streampipes/pull/1438#discussion_r1155364517


##########
.github/workflows/osv-scanner.yml:
##########
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: OSV Scanner
+
+on:
+  schedule:
+    - cron: '0 0 1 * *'
+
+jobs:
+  run-osv-scanner:
+    name: Run OSV Scanner
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+      - name: Scan for vulnerabilities
+        run: |
+          docker run --rm -v $PWD:/repo -w /repo ghcr.io/google/osv-scanner:latest --format markdown -r . |  grep -vE '^Scanned.*packages$' > VULNERABILITY.md

Review Comment:
   Sure you need to do the checkout step, but you should do it as a separate step for the sake of clarity
   
   Maybe I get you wrong, but why should I need to install `osv-scanner` when using `ghcr.io/google/osv-scanner:latest`? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org