You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Simon Willnauer (JIRA)" <ji...@apache.org> on 2012/05/12 10:45:48 UTC

[jira] [Created] (LUCENE-4051) Fix File Headers for Lucene40 StoredFields & TermVectors

Simon Willnauer created LUCENE-4051:
---------------------------------------

             Summary: Fix File Headers for Lucene40 StoredFields & TermVectors
                 Key: LUCENE-4051
                 URL: https://issues.apache.org/jira/browse/LUCENE-4051
             Project: Lucene - Java
          Issue Type: Task
          Components: core/codecs
    Affects Versions: 4.0
            Reporter: Simon Willnauer
            Assignee: Simon Willnauer
             Fix For: 4.0


Currently we still write the "old" file header format in Lucene40StoredFieldFormat & Lucene40TermVectorsFormat. We should cut over to use CodecUtil and reset the versioning before we release Lucene 4.0

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Re: [jira] [Resolved] (LUCENE-4051) Fix File Headers for Lucene40 StoredFields & TermVectors

Posted by Robert Muir <rc...@gmail.com>.
yes

On Wed, May 23, 2012 at 12:14 PM, Ryan McKinley <ry...@gmail.com> wrote:
> For 4.0-alpha, are there other known file format changes in the works?
>
>
>>
>> committed to trunk in rev. 1341768. I send out a headsup mail to the dev list since this breaks the index file format.
>>
>> thanks for reviewing.... lets get 4.0-alpha out!
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>



-- 
lucidimagination.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Re: [jira] [Resolved] (LUCENE-4051) Fix File Headers for Lucene40 StoredFields & TermVectors

Posted by Ryan McKinley <ry...@gmail.com>.
For 4.0-alpha, are there other known file format changes in the works?


>
> committed to trunk in rev. 1341768. I send out a headsup mail to the dev list since this breaks the index file format.
>
> thanks for reviewing.... lets get 4.0-alpha out!
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-4051) Fix File Headers for Lucene40 StoredFields & TermVectors

Posted by "Simon Willnauer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Willnauer updated LUCENE-4051:
------------------------------------

    Attachment: LUCENE-4051.patch

bq. By the way: we can use CodecUtil.headerLength to have a static final
for the length of the header (rather than getFilePointer).

new patch using a static HEADER_LENGTH for this. thanks robert for the pointer.
                
> Fix File Headers for Lucene40 StoredFields & TermVectors
> --------------------------------------------------------
>
>                 Key: LUCENE-4051
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4051
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: core/codecs
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 4.0
>
>         Attachments: LUCENE-4051.patch, LUCENE-4051.patch
>
>
> Currently we still write the "old" file header format in Lucene40StoredFieldFormat & Lucene40TermVectorsFormat. We should cut over to use CodecUtil and reset the versioning before we release Lucene 4.0

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Resolved] (LUCENE-4051) Fix File Headers for Lucene40 StoredFields & TermVectors

Posted by "Simon Willnauer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Willnauer resolved LUCENE-4051.
-------------------------------------

    Resolution: Fixed

committed to trunk in rev. 1341768. I send out a headsup mail to the dev list since this breaks the index file format.

thanks for reviewing.... lets get 4.0-alpha out!
                
> Fix File Headers for Lucene40 StoredFields & TermVectors
> --------------------------------------------------------
>
>                 Key: LUCENE-4051
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4051
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: core/codecs
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 4.0
>
>         Attachments: LUCENE-4051.patch, LUCENE-4051.patch, LUCENE-4051.patch, LUCENE-4051.patch, LUCENE-4051.patch
>
>
> Currently we still write the "old" file header format in Lucene40StoredFieldFormat & Lucene40TermVectorsFormat. We should cut over to use CodecUtil and reset the versioning before we release Lucene 4.0

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-4051) Fix File Headers for Lucene40 StoredFields & TermVectors

Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281700#comment-13281700 ] 

Uwe Schindler commented on LUCENE-4051:
---------------------------------------

Thank you very much! Now file formats are finally consistent. Maybe our index files' consistent magic numbers now also get added to the "file" unix command :-)
                
> Fix File Headers for Lucene40 StoredFields & TermVectors
> --------------------------------------------------------
>
>                 Key: LUCENE-4051
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4051
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: core/codecs
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 4.0
>
>         Attachments: LUCENE-4051.patch, LUCENE-4051.patch, LUCENE-4051.patch, LUCENE-4051.patch, LUCENE-4051.patch
>
>
> Currently we still write the "old" file header format in Lucene40StoredFieldFormat & Lucene40TermVectorsFormat. We should cut over to use CodecUtil and reset the versioning before we release Lucene 4.0

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-4051) Fix File Headers for Lucene40 StoredFields & TermVectors

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274331#comment-13274331 ] 

Robert Muir commented on LUCENE-4051:
-------------------------------------

One more comment: i think actually we should use different codecnames for each file.

(Like for .fdt versus .fdx and so on for the 3 term vectors files). This way we are 
validating that we actually read the stream we think we are reading.

                
> Fix File Headers for Lucene40 StoredFields & TermVectors
> --------------------------------------------------------
>
>                 Key: LUCENE-4051
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4051
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: core/codecs
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 4.0
>
>         Attachments: LUCENE-4051.patch, LUCENE-4051.patch
>
>
> Currently we still write the "old" file header format in Lucene40StoredFieldFormat & Lucene40TermVectorsFormat. We should cut over to use CodecUtil and reset the versioning before we release Lucene 4.0

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-4051) Fix File Headers for Lucene40 StoredFields & TermVectors

Posted by "Simon Willnauer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Willnauer updated LUCENE-4051:
------------------------------------

    Attachment: LUCENE-4051.patch

bq. avadocs look good: trivial nitpick i noticed some relics in TermVectorsFormat such as:

good that you reviewed it! I missed those! here is an updated patch. I plan to commit this soon...
                
> Fix File Headers for Lucene40 StoredFields & TermVectors
> --------------------------------------------------------
>
>                 Key: LUCENE-4051
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4051
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: core/codecs
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 4.0
>
>         Attachments: LUCENE-4051.patch, LUCENE-4051.patch, LUCENE-4051.patch, LUCENE-4051.patch, LUCENE-4051.patch
>
>
> Currently we still write the "old" file header format in Lucene40StoredFieldFormat & Lucene40TermVectorsFormat. We should cut over to use CodecUtil and reset the versioning before we release Lucene 4.0

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-4051) Fix File Headers for Lucene40 StoredFields & TermVectors

Posted by "Simon Willnauer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276617#comment-13276617 ] 

Simon Willnauer commented on LUCENE-4051:
-----------------------------------------

bq. Can you update the fileformat javadocs (in Lucene40*Format.java) to document the codec header?
absolutely. this is still WIP since I need to check other files if we can / should make it writing a per-file header.
                
> Fix File Headers for Lucene40 StoredFields & TermVectors
> --------------------------------------------------------
>
>                 Key: LUCENE-4051
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4051
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: core/codecs
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 4.0
>
>         Attachments: LUCENE-4051.patch, LUCENE-4051.patch, LUCENE-4051.patch
>
>
> Currently we still write the "old" file header format in Lucene40StoredFieldFormat & Lucene40TermVectorsFormat. We should cut over to use CodecUtil and reset the versioning before we release Lucene 4.0

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-4051) Fix File Headers for Lucene40 StoredFields & TermVectors

Posted by "Simon Willnauer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Willnauer updated LUCENE-4051:
------------------------------------

    Attachment: LUCENE-4051.patch

update codec format documenation. I think its ready...
                
> Fix File Headers for Lucene40 StoredFields & TermVectors
> --------------------------------------------------------
>
>                 Key: LUCENE-4051
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4051
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: core/codecs
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 4.0
>
>         Attachments: LUCENE-4051.patch, LUCENE-4051.patch, LUCENE-4051.patch, LUCENE-4051.patch
>
>
> Currently we still write the "old" file header format in Lucene40StoredFieldFormat & Lucene40TermVectorsFormat. We should cut over to use CodecUtil and reset the versioning before we release Lucene 4.0

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-4051) Fix File Headers for Lucene40 StoredFields & TermVectors

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273922#comment-13273922 ] 

Michael McCandless commented on LUCENE-4051:
--------------------------------------------

+1
                
> Fix File Headers for Lucene40 StoredFields & TermVectors
> --------------------------------------------------------
>
>                 Key: LUCENE-4051
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4051
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: core/codecs
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 4.0
>
>         Attachments: LUCENE-4051.patch
>
>
> Currently we still write the "old" file header format in Lucene40StoredFieldFormat & Lucene40TermVectorsFormat. We should cut over to use CodecUtil and reset the versioning before we release Lucene 4.0

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-4051) Fix File Headers for Lucene40 StoredFields & TermVectors

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281338#comment-13281338 ] 

Robert Muir commented on LUCENE-4051:
-------------------------------------

+1 to commit, thanks for working this! Lets get this in asap. as soon as file formats 
changes are solidified we can start working towards a release candidate for 4.0 alpha :)
                
> Fix File Headers for Lucene40 StoredFields & TermVectors
> --------------------------------------------------------
>
>                 Key: LUCENE-4051
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4051
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: core/codecs
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 4.0
>
>         Attachments: LUCENE-4051.patch, LUCENE-4051.patch, LUCENE-4051.patch, LUCENE-4051.patch, LUCENE-4051.patch
>
>
> Currently we still write the "old" file header format in Lucene40StoredFieldFormat & Lucene40TermVectorsFormat. We should cut over to use CodecUtil and reset the versioning before we release Lucene 4.0

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-4051) Fix File Headers for Lucene40 StoredFields & TermVectors

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273953#comment-13273953 ] 

Robert Muir commented on LUCENE-4051:
-------------------------------------

By the way: we can use CodecUtil.headerLength to have a static final
for the length of the header (rather than getFilePointer).

I think in general we should do this since the codec name (and thus
header length) is still fixed.
                
> Fix File Headers for Lucene40 StoredFields & TermVectors
> --------------------------------------------------------
>
>                 Key: LUCENE-4051
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4051
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: core/codecs
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 4.0
>
>         Attachments: LUCENE-4051.patch
>
>
> Currently we still write the "old" file header format in Lucene40StoredFieldFormat & Lucene40TermVectorsFormat. We should cut over to use CodecUtil and reset the versioning before we release Lucene 4.0

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-4051) Fix File Headers for Lucene40 StoredFields & TermVectors

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280233#comment-13280233 ] 

Robert Muir commented on LUCENE-4051:
-------------------------------------

javadocs look good: trivial nitpick i noticed some relics in TermVectorsFormat such as:   
{noformat}
* <p>Document (.tvd) --&gt; TVDVersion&lt;NumFields, FieldNums,
{noformat}

I think TVDVersion should just say Header (i noticed this for TVF etc too)
                
> Fix File Headers for Lucene40 StoredFields & TermVectors
> --------------------------------------------------------
>
>                 Key: LUCENE-4051
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4051
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: core/codecs
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 4.0
>
>         Attachments: LUCENE-4051.patch, LUCENE-4051.patch, LUCENE-4051.patch, LUCENE-4051.patch
>
>
> Currently we still write the "old" file header format in Lucene40StoredFieldFormat & Lucene40TermVectorsFormat. We should cut over to use CodecUtil and reset the versioning before we release Lucene 4.0

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-4051) Fix File Headers for Lucene40 StoredFields & TermVectors

Posted by "Simon Willnauer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Willnauer updated LUCENE-4051:
------------------------------------

    Attachment: LUCENE-4051.patch

here is a new patch adding per file headers (while reusing the version). I also cut over the docvalues headers to be per file.

I think this is a sep. issues but if we can batch up File Format changes I think we should do it. I will look for other codecs to get this consistent where possible.


                
> Fix File Headers for Lucene40 StoredFields & TermVectors
> --------------------------------------------------------
>
>                 Key: LUCENE-4051
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4051
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: core/codecs
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 4.0
>
>         Attachments: LUCENE-4051.patch, LUCENE-4051.patch, LUCENE-4051.patch
>
>
> Currently we still write the "old" file header format in Lucene40StoredFieldFormat & Lucene40TermVectorsFormat. We should cut over to use CodecUtil and reset the versioning before we release Lucene 4.0

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-4051) Fix File Headers for Lucene40 StoredFields & TermVectors

Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276566#comment-13276566 ] 

Robert Muir commented on LUCENE-4051:
-------------------------------------

Patch looks good! 

Can you update the fileformat javadocs (in Lucene40*Format.java) to document the codec header?
In the other places we just treat it like a primitive type and link it to CodecUtil#writeHeader where its
format is described in detail.
                
> Fix File Headers for Lucene40 StoredFields & TermVectors
> --------------------------------------------------------
>
>                 Key: LUCENE-4051
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4051
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: core/codecs
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 4.0
>
>         Attachments: LUCENE-4051.patch, LUCENE-4051.patch, LUCENE-4051.patch
>
>
> Currently we still write the "old" file header format in Lucene40StoredFieldFormat & Lucene40TermVectorsFormat. We should cut over to use CodecUtil and reset the versioning before we release Lucene 4.0

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-4051) Fix File Headers for Lucene40 StoredFields & TermVectors

Posted by "Simon Willnauer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon Willnauer updated LUCENE-4051:
------------------------------------

    Attachment: LUCENE-4051.patch

here is a first patch
                
> Fix File Headers for Lucene40 StoredFields & TermVectors
> --------------------------------------------------------
>
>                 Key: LUCENE-4051
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4051
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: core/codecs
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 4.0
>
>         Attachments: LUCENE-4051.patch
>
>
> Currently we still write the "old" file header format in Lucene40StoredFieldFormat & Lucene40TermVectorsFormat. We should cut over to use CodecUtil and reset the versioning before we release Lucene 4.0

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org