You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Joe Bowser (JIRA)" <ji...@apache.org> on 2012/08/23 18:09:42 UTC

[jira] [Resolved] (CB-1156) Android app creation is broken in several ways!

     [ https://issues.apache.org/jira/browse/CB-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joe Bowser resolved CB-1156.
----------------------------

    Resolution: Not A Problem

It seems that this bug reads more like personal preference than an actual issue given the discussion around this.  There is a standard for indentation used in Cordova which is four spaces (tabs are bad, even in Java). As for the generated file, it is just that, generated.

Also, in the future, saying what's wrong works better than just saying "It's broken"
                
> Android app creation is broken in several ways!
> -----------------------------------------------
>
>                 Key: CB-1156
>                 URL: https://issues.apache.org/jira/browse/CB-1156
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: 2.0.0
>            Reporter: Olivier Louvignes
>            Assignee: Anis Kadri
>            Priority: Minor
>              Labels: android
>
> The experience of starting a new Android app is just really bad.
> When we use the bin/create script there is a lot of things missing :
> -> SplashScreen?!
> I just can't understand why this is lacking. It is an obvious need & everyone has to waste time figuring out how to make it work by themselves
> -> MacOSX is broken
> Either using latest Lion or any version with Macports + GNUTools (replacing deprecated versions bundled with OSX for licensing issues - common for most developers).
> -> The XML is missing required keys (targetSDKpath) & having invalid stuff inside it (xLargeScreen).
> -> Most files are badly indented. Does not respect the Google guidelines for JAVA.
> I've done most of the fixing myself:
> You can find this (work in progress) there :
> - https://github.com/mgcrea/incubator-cordova-android/commits/patches-create
> I'm quite disappointed on how you release a 2.0 without taking the hour needed to clean this mess. Instead a few hundred people will encounter the same issues & have a bad idea on Cordova/Phonegap.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira