You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/07/21 13:27:05 UTC

[GitHub] [beam] TobKed commented on a change in pull request #12318: [BEAM-10538] Add cross-platform test suite on GitHub Actions

TobKed commented on a change in pull request #12318:
URL: https://github.com/apache/beam/pull/12318#discussion_r458094963



##########
File path: sdks/python/tox.ini
##########
@@ -33,6 +33,7 @@ extras = test
 whitelist_externals =
   false
   time
+  bash

Review comment:
       I added bash to whitelist to get rid of warning messages. It is raised because I had to explicitly use bash in *-win tox testenvs. Bash is available on the github runners:
   
   > When specifying a bash shell on Windows, the bash shell included with Git for Windows is  used.
   
   https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#using-a-specific-shell
   
   false and time command are available in mentioned bash shell on windows




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org