[GitHub] sharonlx opened a new pull request #5034: use real dom to finished virtualaztion

[GitBox <gi...@apache.org>]

sharonlx opened a new pull request #5034: use real dom to finished virtualaztion
URL: https://github.com/apache/incubator-superset/pull/5034
 
 
   when dashbord filter-box control send ajax frequently， 
   
   in Chart.jsx
   ``` 
   <ChartBody
               containerId={this.containerId}
               vizType={this.props.vizType}
               height={this.height}
               width={this.width}
               faded={this.props.refreshOverlayVisible && !this.props.errorMessage}
               ref={(inner) => {
                 this.container = inner;
               }}
             />
   ```
   this.container can be null and lead to js error when virtulazation. there is no need to use virtual dom and to render chart, so use read dom.
   ```
       slice.container.css('height', height + 'px'); // slice.container will be null
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org