You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/08/15 22:42:20 UTC
[jira] [Commented] (BEAM-557) Test-scoped dependencies should be
excluded from shading package relocation
[ https://issues.apache.org/jira/browse/BEAM-557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15421818#comment-15421818 ]
ASF GitHub Bot commented on BEAM-557:
-------------------------------------
GitHub user swegner opened a pull request:
https://github.com/apache/incubator-beam/pull/832
[BEAM-557] Exclude guava-testlib from shading relocation
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
Previously, guava-testlib guava-testlib was being relocated as part of
the shading process, but test-scope dependencies aren't bundled in the
uber-jar. As a result, the output JAR was unusable without recreating the
same shading rules in a consuming project.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/swegner/incubator-beam test-shading
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/832.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #832
----
commit 03aafacafa2b917d8469dbd7043caf87dfe99e5f
Author: Scott Wegner <sw...@google.com>
Date: 2016-08-15T22:39:34Z
Exclude guava-testlib from shading relocation
Previously, guava-testlib guava-testlib was being relocated as part of
the shading process, but test-scope dependencies aren't bundled in the
uber-jar. As a result, the output JAR was unusable without recreating the
same shading rules in a consuming project.
----
> Test-scoped dependencies should be excluded from shading package relocation
> ---------------------------------------------------------------------------
>
> Key: BEAM-557
> URL: https://issues.apache.org/jira/browse/BEAM-557
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Scott Wegner
> Assignee: Scott Wegner
> Priority: Minor
>
> Currently, guava-testlib is being relocated as part of the shading process, but test-scope dependencies aren't bundled in the uber-jar. As a result, the output JAR is unusable without recreating the same shading rules in a consuming project.
> Note that this does not effect our maven test process because tests are run on the unshaded JAR.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)