You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2019/06/25 15:46:01 UTC
[jira] [Commented] (IMPALA-6299) IRBuilder codegen should using
LLVMCodeGen::cpu_attrs instead of CpuInfo to determine valid instructions
[ https://issues.apache.org/jira/browse/IMPALA-6299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16872455#comment-16872455 ]
ASF subversion and git services commented on IMPALA-6299:
---------------------------------------------------------
Commit 44794423bada8a44a2b7b05879764c6bc13b26fd in impala's branch refs/heads/2.x from poojanilangekar
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=4479442 ]
IMPALA-6299: Use LlvmCodeGen's internal list of white-listed CPU attributes for handcrafting IRs
Previously, the IRBuilder of the LlvmCodeGen class used CpuInfo's
list of enabled features to determine the validity of certain
instructions to emit intrinsics. It did not consider the whitelist
which passed while initializing the LlvmCodeGen class. Now, the
IRBuilder inspects its own CPU attributes before emitting
instruction. This change also adds functionality to modify the CPU
attributes of the LlvmCodeGen class for testing.
Testing: Verified that the current tests which use and modify
CpuInfo produce expected results.
Change-Id: Ifece8949c143146d2a1b38d72d21c2d733bed90f
Reviewed-on: http://gerrit.cloudera.org:8080/10979
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> IRBuilder codegen should using LLVMCodeGen::cpu_attrs instead of CpuInfo to determine valid instructions
> --------------------------------------------------------------------------------------------------------
>
> Key: IMPALA-6299
> URL: https://issues.apache.org/jira/browse/IMPALA-6299
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Reporter: Tim Armstrong
> Assignee: Pooja Nilangekar
> Priority: Major
> Labels: codegen, newbie
> Fix For: Impala 3.1.0
>
>
> This came out of a discussion on this code review: https://gerrit.cloudera.org/#/c/8802/
> The idea is that IRBuilder code that emits intrinsics should only do so if we have those CPU features enabled in LLVM. Otherwise codegen will fail to compile the emitted instructions.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org