You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by serbaut <gi...@git.apache.org> on 2017/01/30 15:19:26 UTC
[GitHub] cloudstack pull request #1919: CLOUDSTACK-9763: set ssh public key when crea...
GitHub user serbaut opened a pull request:
https://github.com/apache/cloudstack/pull/1919
CLOUDSTACK-9763: set ssh public key when creating vm data
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/serbaut/cloudstack CLOUDSTACK-9763
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1919.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1919
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1919: CLOUDSTACK-9763: set ssh public key when creating vm...
Posted by serbaut <gi...@git.apache.org>.
Github user serbaut commented on the issue:
https://github.com/apache/cloudstack/pull/1919
The VPC VR maintains metadata (http://docs.cloudstack.apache.org/projects/cloudstack-administration/en/4.8/virtual_machines/user-data.html) as static files in /var/www/html/metadata. When a VR is destroyed and recreated (by e.g. "restart with cleanup") this metadata is rebuilt by createVmDataCommandForVMs(). public-keys is missing from that function so it becomes empty after the rebuild and a request for latest/meta-data/public-keys no longer returns the correct key.
This PR adds public-key to the rebuild.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1919: CLOUDSTACK-9763: set ssh public key when creating vm...
Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1919
@serbaut I would only like to make a few questions to see if I understood the issue here, before evaluating the code any further.
When you first deploy the VM, the keys are delivered to the newly deployed VM, right? The problem only happens on reboots?
Do we need to always keep sending the same access keys? Is not one time enough? Of course, if the keys are changed, we should send them; but otherwise, it feels that we should not need to keep sending them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1919: CLOUDSTACK-9763: set ssh public key when creating vm...
Posted by pdion891 <gi...@git.apache.org>.
Github user pdion891 commented on the issue:
https://github.com/apache/cloudstack/pull/1919
This is usefull when using VPC.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1919: CLOUDSTACK-9763: set ssh public key when creating vm...
Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1919
Thanks for the explanation @serbaut. That is exactly why I asked; so, it is not a reboot/restart per se. It is a re-deploy; the old virtual machine is destroyed and a new one is deployed (or maybe a reset of the VHD of the VM). By VM here I mean VR (which at the end of the day is a VM).
@serbaut, could you add these explanations on the PR description and Jira ticket (https://issues.apache.org/jira/browse/CLOUDSTACK-9763)? At least for me, this was not clear.
Thanks for the fix ;)
Code LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1919: CLOUDSTACK-9763: set ssh public key when creating vm...
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1919
I agree with @serbaut , different from password which is applied to VR only once, the public keys should be set in VR each time when we recreate a VR.
this LGTM+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---