You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2022/03/22 04:39:46 UTC
[GitHub] [james-project] chibenwa opened a new pull request #926: JAMES-3715 Small round of Netty4 polishing
chibenwa opened a new pull request #926:
URL: https://github.com/apache/james-project/pull/926
Rebased version of https://github.com/apache/james-project/pull/903
TODO quich performance checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #926: JAMES-3715 Small round of Netty4 polishing
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #926:
URL: https://github.com/apache/james-project/pull/926#issuecomment-1081480233
Forced pushed to remove the last commit which was unrelated.. Was :green_apple:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on a change in pull request #926: JAMES-3715 Small round of Netty4 polishing
Posted by GitBox <gi...@apache.org>.
Arsnael commented on a change in pull request #926:
URL: https://github.com/apache/james-project/pull/926#discussion_r832819000
##########
File path: mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/GhostMailbox.java
##########
@@ -35,6 +35,14 @@
public static final String TYPE = "type";
public static final String MAILBOX_ID = "mailboxId";
+ public static boolean isDebugEnabled() {
+ return LOGGER.isDebugEnabled();
+ }
+
+ public static boolean isInfoEnabled() {
+ return LOGGER.isDebugEnabled();
Review comment:
You return here if debug is enabled, nothing to do with info...
I don't think the method `isInfoEnabled` would be used anyway, and it's not in your code for now. We can remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #926: JAMES-3715 Small round of Netty4 polishing
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #926:
URL: https://github.com/apache/james-project/pull/926#issuecomment-1082605754
Forced pushed to solve a rebase conflict...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org