[GitHub] mistercrunch commented on issue #6781: Merge default feature flags and user defined feature flags

[GitBox <gi...@apache.org>]

mistercrunch commented on issue #6781: Merge default feature flags and user defined feature flags
URL: https://github.com/apache/incubator-superset/pull/6781#issuecomment-459848093
 
 
   I'm doing some more thinking on this and would like to extend the feature to be more dynamic, so that we can actually turn features on and off based on user attributes or perhaps other context. It'd be powerful to be able to use a hook here to do progressive releases (1%, 5%, 10%, ...), or based on roles (say an 'early_adopter' role).
   
   As a static-per-environment feature (like it is now) it doesn't offer much more than the `app.config` offers already. Let's think of ways to make it more dynamic.
   
   At first I was thinking about exposing a function in config `GET_FEATURE_FLAGS()`, and by its nature it'd have access to the `user` and `request` objects that are provided by Flask/FAB. Since we want the framework to work both on the backend AND frontend, I think it has to be a function that returns the whole dict of flags so that it can be computed on the backend and sent to the frontend (as opposed to a `GET_SINGLE_FEATURE_FLAG(flag)` function).
   
   What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org