You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by amansinha100 <gi...@git.apache.org> on 2017/09/07 18:26:27 UTC

[GitHub] drill pull request #926: DRILL-5269 Make DirectSubScan Jackson JSON deserial...

Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/926#discussion_r137619550
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/RecordReader.java ---
    @@ -26,6 +26,9 @@
     import org.apache.drill.exec.record.MaterializedField;
     import org.apache.drill.exec.vector.ValueVector;
     
    +import com.fasterxml.jackson.annotation.JsonTypeInfo;
    +
    +@JsonTypeInfo(use=JsonTypeInfo.Id.NAME, include=JsonTypeInfo.As.WRAPPER_OBJECT, property="type")
    --- End diff --
    
    I am not a Jackson expert; since this annotation is in the core RecordReader interface, what impact does it have on all the implementers of this interface ? 


---