You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Dennis Lundberg <de...@apache.org> on 2006/06/01 00:06:37 UTC
[maven-maven1-plugin] 3 patches awaiting review
Hi all
Work on the maven-maven1-plugin is coming along nicely. So far I've
submitted 3 patches to JIRA and a couple more are in the pipeline.
Coming up next are:
- use maven-model-converter instead of bundled class
- property configuration converters for the checkstyle, jar and javadoc
plugins with test cases
- tweaks to the xml generation so that the configuration elements get
pretty-printed correctly
- documentation
- after that I think we can consider integrating it into the
maven-one-plugin
It's getting difficult to create more patches now though, as the new
work rely on the previous patches. So I would like to ask if someone
could spare some time to review, and hopefully commit, the patches for:
- http://jira.codehaus.org/browse/MNG-2320
- http://jira.codehaus.org/browse/MNG-2327
- http://jira.codehaus.org/browse/MNG-2332
Thanks!
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [maven-maven1-plugin] 3 patches awaiting review
Posted by Dennis Lundberg <de...@apache.org>.
I must say that I agree with Brett here. My goal has been to post small
specific patches to JIRA, so that they can be easily reviewed. I know,
from own experience, how difficult it can be to review a patch that does
*everything*. It makes it hard to see what is really going on.
However, if Carlos, or someone else, is willing to review and commit
larger patches I'm OK with that too. It makes life a little easier at my
end.
I've created a new version of the patch that had conflicts. It might
have occurred because the patches was not applied in the same order that
they were created. This illuminates one problem that many small patches
can have.
Until I hear back from you, with notice of how you want to do with
patches from here on, I will not post any new patches to JIRA. It will
not stop me from working on the code though :)
Finally, I would like to thank Carlos for taking the time to review and
commit the work I have done.
--
Dennis Lundberg
Brett Porter wrote:
> I disagree in general - it's easier to review smaller, specific patches,
> especially if one were to be rejected and the others accepted. Of
> course, the danger is that they build on top of each other and then it
> gets harder.
>
> That said, I'm not the one who put my hand up to apply the patches
> (thanks, Carlos :)
>
> - Brett
>
> Carlos Sanchez wrote:
>> ASs right now you are the only one working on it you should post a
>> patch every week or so to reduce the amount of effort needed
>>
>> On 6/2/06, Dennis Lundberg <de...@apache.org> wrote:
>>> Hello again
>>>
>>> There are now three more patches available in JIRA, for the
>>> maven1-plugin, that needs some tender love and care (i.e. review and
>>> commit) :)
>>> - http://jira.codehaus.org/browse/MNG-2335
>>> - http://jira.codehaus.org/browse/MNG-2336
>>> - http://jira.codehaus.org/browse/MNG-2338
>>>
>>> These patches cover points 1 and 3 below, and prepares for point
>>> number 2.
>>>
>>> Dennis Lundberg wrote:
>>> > Hi all
>>> >
>>> > Work on the maven-maven1-plugin is coming along nicely. So far I've
>>> > submitted 3 patches to JIRA and a couple more are in the pipeline.
>>> > Coming up next are:
>>> > - use maven-model-converter instead of bundled class
>>> > - property configuration converters for the checkstyle, jar and
>>> javadoc
>>> > plugins with test cases
>>> > - tweaks to the xml generation so that the configuration elements get
>>> > pretty-printed correctly
>>> > - documentation
>>> > - after that I think we can consider integrating it into the
>>> > maven-one-plugin
>>> >
>>> > It's getting difficult to create more patches now though, as the new
>>> > work rely on the previous patches. So I would like to ask if someone
>>> > could spare some time to review, and hopefully commit, the patches
>>> for:
>>> > - http://jira.codehaus.org/browse/MNG-2320
>>> > - http://jira.codehaus.org/browse/MNG-2327
>>> > - http://jira.codehaus.org/browse/MNG-2332
>>> >
>>> > Thanks!
>>> >
>>>
>>>
>>> --
>>> Dennis Lundberg
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>>
>>
>>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [maven-maven1-plugin] 3 patches awaiting review
Posted by Brett Porter <br...@apache.org>.
I disagree in general - it's easier to review smaller, specific patches,
especially if one were to be rejected and the others accepted. Of
course, the danger is that they build on top of each other and then it
gets harder.
That said, I'm not the one who put my hand up to apply the patches
(thanks, Carlos :)
- Brett
Carlos Sanchez wrote:
> ASs right now you are the only one working on it you should post a
> patch every week or so to reduce the amount of effort needed
>
> On 6/2/06, Dennis Lundberg <de...@apache.org> wrote:
>> Hello again
>>
>> There are now three more patches available in JIRA, for the
>> maven1-plugin, that needs some tender love and care (i.e. review and
>> commit) :)
>> - http://jira.codehaus.org/browse/MNG-2335
>> - http://jira.codehaus.org/browse/MNG-2336
>> - http://jira.codehaus.org/browse/MNG-2338
>>
>> These patches cover points 1 and 3 below, and prepares for point
>> number 2.
>>
>> Dennis Lundberg wrote:
>> > Hi all
>> >
>> > Work on the maven-maven1-plugin is coming along nicely. So far I've
>> > submitted 3 patches to JIRA and a couple more are in the pipeline.
>> > Coming up next are:
>> > - use maven-model-converter instead of bundled class
>> > - property configuration converters for the checkstyle, jar and javadoc
>> > plugins with test cases
>> > - tweaks to the xml generation so that the configuration elements get
>> > pretty-printed correctly
>> > - documentation
>> > - after that I think we can consider integrating it into the
>> > maven-one-plugin
>> >
>> > It's getting difficult to create more patches now though, as the new
>> > work rely on the previous patches. So I would like to ask if someone
>> > could spare some time to review, and hopefully commit, the patches for:
>> > - http://jira.codehaus.org/browse/MNG-2320
>> > - http://jira.codehaus.org/browse/MNG-2327
>> > - http://jira.codehaus.org/browse/MNG-2332
>> >
>> > Thanks!
>> >
>>
>>
>> --
>> Dennis Lundberg
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>
>
--
Brett Porter <br...@apache.org>
Apache Maven - http://maven.apache.org/
Better Builds with Maven - http://library.mergere.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [maven-maven1-plugin] 3 patches awaiting review
Posted by Carlos Sanchez <ca...@apache.org>.
ASs right now you are the only one working on it you should post a
patch every week or so to reduce the amount of effort needed
On 6/2/06, Dennis Lundberg <de...@apache.org> wrote:
> Hello again
>
> There are now three more patches available in JIRA, for the
> maven1-plugin, that needs some tender love and care (i.e. review and
> commit) :)
> - http://jira.codehaus.org/browse/MNG-2335
> - http://jira.codehaus.org/browse/MNG-2336
> - http://jira.codehaus.org/browse/MNG-2338
>
> These patches cover points 1 and 3 below, and prepares for point number 2.
>
> Dennis Lundberg wrote:
> > Hi all
> >
> > Work on the maven-maven1-plugin is coming along nicely. So far I've
> > submitted 3 patches to JIRA and a couple more are in the pipeline.
> > Coming up next are:
> > - use maven-model-converter instead of bundled class
> > - property configuration converters for the checkstyle, jar and javadoc
> > plugins with test cases
> > - tweaks to the xml generation so that the configuration elements get
> > pretty-printed correctly
> > - documentation
> > - after that I think we can consider integrating it into the
> > maven-one-plugin
> >
> > It's getting difficult to create more patches now though, as the new
> > work rely on the previous patches. So I would like to ask if someone
> > could spare some time to review, and hopefully commit, the patches for:
> > - http://jira.codehaus.org/browse/MNG-2320
> > - http://jira.codehaus.org/browse/MNG-2327
> > - http://jira.codehaus.org/browse/MNG-2332
> >
> > Thanks!
> >
>
>
> --
> Dennis Lundberg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
I could give you my word as a Spaniard.
No good. I've known too many Spaniards.
-- The Princess Bride
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [maven-maven1-plugin] 3 patches awaiting review
Posted by Dennis Lundberg <de...@apache.org>.
Hello again
There are now three more patches available in JIRA, for the
maven1-plugin, that needs some tender love and care (i.e. review and
commit) :)
- http://jira.codehaus.org/browse/MNG-2335
- http://jira.codehaus.org/browse/MNG-2336
- http://jira.codehaus.org/browse/MNG-2338
These patches cover points 1 and 3 below, and prepares for point number 2.
Dennis Lundberg wrote:
> Hi all
>
> Work on the maven-maven1-plugin is coming along nicely. So far I've
> submitted 3 patches to JIRA and a couple more are in the pipeline.
> Coming up next are:
> - use maven-model-converter instead of bundled class
> - property configuration converters for the checkstyle, jar and javadoc
> plugins with test cases
> - tweaks to the xml generation so that the configuration elements get
> pretty-printed correctly
> - documentation
> - after that I think we can consider integrating it into the
> maven-one-plugin
>
> It's getting difficult to create more patches now though, as the new
> work rely on the previous patches. So I would like to ask if someone
> could spare some time to review, and hopefully commit, the patches for:
> - http://jira.codehaus.org/browse/MNG-2320
> - http://jira.codehaus.org/browse/MNG-2327
> - http://jira.codehaus.org/browse/MNG-2332
>
> Thanks!
>
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [maven-maven1-plugin] 3 patches awaiting review
Posted by Dennis Lundberg <de...@apache.org>.
Thanks!
Carlos Sanchez wrote:
> Done. Thanks.
>
> On 5/31/06, Dennis Lundberg <de...@apache.org> wrote:
>> Hi all
>>
>> Work on the maven-maven1-plugin is coming along nicely. So far I've
>> submitted 3 patches to JIRA and a couple more are in the pipeline.
>> Coming up next are:
>> - use maven-model-converter instead of bundled class
>> - property configuration converters for the checkstyle, jar and javadoc
>> plugins with test cases
>> - tweaks to the xml generation so that the configuration elements get
>> pretty-printed correctly
>> - documentation
>> - after that I think we can consider integrating it into the
>> maven-one-plugin
>>
>> It's getting difficult to create more patches now though, as the new
>> work rely on the previous patches. So I would like to ask if someone
>> could spare some time to review, and hopefully commit, the patches for:
>> - http://jira.codehaus.org/browse/MNG-2320
>> - http://jira.codehaus.org/browse/MNG-2327
>> - http://jira.codehaus.org/browse/MNG-2332
>>
>> Thanks!
>>
>> --
>> Dennis Lundberg
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>
>
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [maven-maven1-plugin] 3 patches awaiting review
Posted by Carlos Sanchez <ca...@apache.org>.
Done. Thanks.
On 5/31/06, Dennis Lundberg <de...@apache.org> wrote:
> Hi all
>
> Work on the maven-maven1-plugin is coming along nicely. So far I've
> submitted 3 patches to JIRA and a couple more are in the pipeline.
> Coming up next are:
> - use maven-model-converter instead of bundled class
> - property configuration converters for the checkstyle, jar and javadoc
> plugins with test cases
> - tweaks to the xml generation so that the configuration elements get
> pretty-printed correctly
> - documentation
> - after that I think we can consider integrating it into the
> maven-one-plugin
>
> It's getting difficult to create more patches now though, as the new
> work rely on the previous patches. So I would like to ask if someone
> could spare some time to review, and hopefully commit, the patches for:
> - http://jira.codehaus.org/browse/MNG-2320
> - http://jira.codehaus.org/browse/MNG-2327
> - http://jira.codehaus.org/browse/MNG-2332
>
> Thanks!
>
> --
> Dennis Lundberg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
I could give you my word as a Spaniard.
No good. I've known too many Spaniards.
-- The Princess Bride
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org