You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/14 15:20:01 UTC
[GitHub] [airflow] potiuk edited a comment on pull request #19914: Fix mypy errors in airflow utils
potiuk edited a comment on pull request #19914:
URL: https://github.com/apache/airflow/pull/19914#issuecomment-993649750
@ashb - FYI. I actually changed the "StreamLogWriter" approach - rather than extending from IO Abstract class, I extend from IOBase which has implementations for pretty much all of the abstract methods of IO.
Not only cleaner but it will work for Python3.6 as well (Apparently Python3.6 had some non-implemented abstract methods in IO which caused our tests fail with "Can't instantiate abstract class … with abstract methods”
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org