You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "advancedxy (via GitHub)" <gi...@apache.org> on 2023/02/17 02:53:41 UTC
[GitHub] [incubator-uniffle] advancedxy opened a new pull request, #619: [#618] chore: support downloads latest hadoop archives and mirror url
advancedxy opened a new pull request, #619:
URL: https://github.com/apache/incubator-uniffle/pull/619
### What changes were proposed in this pull request?
1. support download latest hadoop archive such as hadoop-2.10.2
2. add `--apache-mirror` for build.sh
### Why are the changes needed?
Fix: #618
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Manually tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #619: [#618] chore(docker): support downloads latest hadoop archives and mirror url
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on code in PR #619:
URL: https://github.com/apache/incubator-uniffle/pull/619#discussion_r1109346615
##########
deploy/kubernetes/docker/build.sh:
##########
@@ -72,9 +79,10 @@ fi
HADOOP_FILE=hadoop-${HADOOP_VERSION}.tar.gz
HADOOP_URL=https://archive.apache.org/dist/hadoop/core/hadoop-${HADOOP_VERSION}/${HADOOP_FILE}
-echo "HADOOP_URL is $HADOOP_URL"
+LATEST_HADOOP_URL=${APACHE_MIRROR}/hadoop/core/hadoop-${HADOOP_VERSION}/${HADOOP_FILE}
Review Comment:
:+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] wangao1236 commented on a diff in pull request #619: [#618] chore(docker): support downloads latest hadoop archives and mirror url
Posted by "wangao1236 (via GitHub)" <gi...@apache.org>.
wangao1236 commented on code in PR #619:
URL: https://github.com/apache/incubator-uniffle/pull/619#discussion_r1109386176
##########
deploy/kubernetes/docker/build.sh:
##########
@@ -51,6 +54,10 @@ while (( "$#" )); do
--help)
exit_with_usage
;;
+ --apache-mirror)
+ APACHE_MIRROR="$2"
Review Comment:
Ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy merged pull request #619: [#618] chore(docker): support downloads latest hadoop archives and mirror url
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy merged PR #619:
URL: https://github.com/apache/incubator-uniffle/pull/619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #619: [#618] chore: support downloads latest hadoop archives and mirror url
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #619:
URL: https://github.com/apache/incubator-uniffle/pull/619#issuecomment-1434033991
# [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/619?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#619](https://codecov.io/gh/apache/incubator-uniffle/pull/619?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dae89c5) into [master](https://codecov.io/gh/apache/incubator-uniffle/commit/4f07b0c3b58db51b5e349bc9c51d39c7c84f55d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4f07b0c) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #619 +/- ##
=========================================
Coverage 60.87% 60.87%
Complexity 1802 1802
=========================================
Files 214 214
Lines 12388 12388
Branches 1045 1045
=========================================
Hits 7541 7541
Misses 4442 4442
Partials 405 405
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #619: [#618] chore(docker): support downloads latest hadoop archives and mirror url
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on code in PR #619:
URL: https://github.com/apache/incubator-uniffle/pull/619#discussion_r1109266046
##########
deploy/kubernetes/docker/build.sh:
##########
@@ -72,9 +79,10 @@ fi
HADOOP_FILE=hadoop-${HADOOP_VERSION}.tar.gz
HADOOP_URL=https://archive.apache.org/dist/hadoop/core/hadoop-${HADOOP_VERSION}/${HADOOP_FILE}
-echo "HADOOP_URL is $HADOOP_URL"
+LATEST_HADOOP_URL=${APACHE_MIRROR}/hadoop/core/hadoop-${HADOOP_VERSION}/${HADOOP_FILE}
Review Comment:
OK, I got it after looking into the issue, maybe call this `HADOOP_URL`, and change line 81 to `ARCHIVE_HADOOP_URL`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on pull request #619: [#618] chore: support downloads latest hadoop archives and mirror url
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on PR #619:
URL: https://github.com/apache/incubator-uniffle/pull/619#issuecomment-1434031729
@kaijchen please help review this, this should be merged before #600, which is too slow when building rss-base image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #619: [#618] chore: support downloads latest hadoop archives and mirror url
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on code in PR #619:
URL: https://github.com/apache/incubator-uniffle/pull/619#discussion_r1109264408
##########
deploy/kubernetes/docker/build.sh:
##########
@@ -72,9 +79,10 @@ fi
HADOOP_FILE=hadoop-${HADOOP_VERSION}.tar.gz
HADOOP_URL=https://archive.apache.org/dist/hadoop/core/hadoop-${HADOOP_VERSION}/${HADOOP_FILE}
-echo "HADOOP_URL is $HADOOP_URL"
+LATEST_HADOOP_URL=${APACHE_MIRROR}/hadoop/core/hadoop-${HADOOP_VERSION}/${HADOOP_FILE}
Review Comment:
Maybe `MIRROR_HADOOP_URL`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #619: [#618] chore(docker): support downloads latest hadoop archives and mirror url
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on code in PR #619:
URL: https://github.com/apache/incubator-uniffle/pull/619#discussion_r1109347783
##########
deploy/kubernetes/docker/build.sh:
##########
@@ -72,9 +79,10 @@ fi
HADOOP_FILE=hadoop-${HADOOP_VERSION}.tar.gz
HADOOP_URL=https://archive.apache.org/dist/hadoop/core/hadoop-${HADOOP_VERSION}/${HADOOP_FILE}
-echo "HADOOP_URL is $HADOOP_URL"
+LATEST_HADOOP_URL=${APACHE_MIRROR}/hadoop/core/hadoop-${HADOOP_VERSION}/${HADOOP_FILE}
Review Comment:
fixed. Please take another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] wangao1236 commented on a diff in pull request #619: [#618] chore(docker): support downloads latest hadoop archives and mirror url
Posted by "wangao1236 (via GitHub)" <gi...@apache.org>.
wangao1236 commented on code in PR #619:
URL: https://github.com/apache/incubator-uniffle/pull/619#discussion_r1109349138
##########
deploy/kubernetes/docker/build.sh:
##########
@@ -51,6 +54,10 @@ while (( "$#" )); do
--help)
exit_with_usage
;;
+ --apache-mirror)
+ APACHE_MIRROR="$2"
Review Comment:
Perhaps we can decide not to replace the default value if the value passed in is empty?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #619: [#618] chore(docker): support downloads latest hadoop archives and mirror url
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on code in PR #619:
URL: https://github.com/apache/incubator-uniffle/pull/619#discussion_r1109359220
##########
deploy/kubernetes/docker/build.sh:
##########
@@ -51,6 +54,10 @@ while (( "$#" )); do
--help)
exit_with_usage
;;
+ --apache-mirror)
+ APACHE_MIRROR="$2"
Review Comment:
yes. But let's defer it in other PRs, other options should also be handled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] advancedxy commented on pull request #619: [#618] chore(docker): support downloads latest hadoop archives and mirror url
Posted by "advancedxy (via GitHub)" <gi...@apache.org>.
advancedxy commented on PR #619:
URL: https://github.com/apache/incubator-uniffle/pull/619#issuecomment-1434224400
ping @kaijchen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org