You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by ol...@apache.org on 2012/09/27 13:25:11 UTC

svn commit: r1390942 - in /httpcomponents/httpasyncclient/trunk: RELEASE_NOTES.txt httpasyncclient/src/main/java/org/apache/http/impl/nio/conn/PoolingClientAsyncConnectionManager.java

Author: olegk
Date: Thu Sep 27 11:25:11 2012
New Revision: 1390942

URL: http://svn.apache.org/viewvc?rev=1390942&view=rev
Log:
HTTPASYNC-28: PoolEntry's expiry information is never updated.
Contributed by Daniel Kulp <dkulp at apache.org>

Modified:
    httpcomponents/httpasyncclient/trunk/RELEASE_NOTES.txt
    httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/conn/PoolingClientAsyncConnectionManager.java

Modified: httpcomponents/httpasyncclient/trunk/RELEASE_NOTES.txt
URL: http://svn.apache.org/viewvc/httpcomponents/httpasyncclient/trunk/RELEASE_NOTES.txt?rev=1390942&r1=1390941&r2=1390942&view=diff
==============================================================================
--- httpcomponents/httpasyncclient/trunk/RELEASE_NOTES.txt (original)
+++ httpcomponents/httpasyncclient/trunk/RELEASE_NOTES.txt Thu Sep 27 11:25:11 2012
@@ -1,8 +1,16 @@
+Changes since 4.0 Beta 3
+
+* [HTTPASYNC-28] PoolEntry's expiry information is never updated.
+  Contributed by Daniel Kulp <dkulp at apache.org>
+
+
 Release 4.0 Beta 3
 -------------------
 
 The 4.0 BETA3 is a maintenance release that picks up the latest bug fixes in the core components.
 
+Changelog:
+
 * Upgraded HttpCore to version 4.2.2
 
 * [HTTPASYNC-26] OSGi bundle import fix.

Modified: httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/conn/PoolingClientAsyncConnectionManager.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/conn/PoolingClientAsyncConnectionManager.java?rev=1390942&r1=1390941&r2=1390942&view=diff
==============================================================================
--- httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/conn/PoolingClientAsyncConnectionManager.java (original)
+++ httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/conn/PoolingClientAsyncConnectionManager.java Thu Sep 27 11:25:11 2012
@@ -201,7 +201,7 @@ public class PoolingClientAsyncConnectio
         }
 
         synchronized (managedConn) {
-            HttpPoolEntry entry = managedConn.detach();
+            HttpPoolEntry entry = managedConn.getPoolEntry();
             if (entry == null) {
                 return;
             }
@@ -230,7 +230,7 @@ public class PoolingClientAsyncConnectio
                     managedConn.setSocketTimeout(0);
                 }
             } finally {
-                this.pool.release(entry, managedConn.isMarkedReusable());
+                this.pool.release(managedConn.detach(), managedConn.isMarkedReusable());
             }
             if (this.log.isDebugEnabled()) {
                 this.log.debug("Connection released: " + format(entry) + formatStats(entry.getRoute()));