[jira] [Commented] (CB-7607) Add xxhdpi and xxxhdpi support to Android Cordova

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-7607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14143119#comment-14143119 ] 

ASF GitHub Bot commented on CB-7607:
------------------------------------

GitHub user sgrebnov opened a pull request:

    https://github.com/apache/cordova-lib/pull/89

    CB-7607 Add xxhdpi and xxxhdpi support to Android Cordova

    https://issues.apache.org/jira/browse/CB-7607
    
    Current Cordova template for Android does not have res sub-folders for xx and xxxhdpi plus due to current splash/icons support implementation it is possible to replace already existing drawables only(see var densities = this.deleteDefaultResource(...)). I don't think we should always keep new hi res images as part of default template due to the their big size so this commit improves splash/icons support implementation to make it possible to add drawables for the densities which are not present in template by default.
    
    Example configuration for xxhdpi and xxxhdpi assets:
    ```
    <icon src="res/android/xxhdpi.png" density="xxhdpi" />
    <icon src="res/android/xxxhdpi.png" density="xxxhdpi" />
    
    <splash src="res/android/land-xxhdpi.png" density="land-xxhdpi" />
    <splash src="res/android/port-xxhdpi.png" density="port-xxhdpi" />
    
    <splash src="res/android/land-xxxhdpi.png" density="land-xxxhdpi" />
    <splash src="res/android/port-xxxhdpi.png" density="port-xxxhdpi" />
    ```


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-lib CB-7607

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/89.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #89
    
----
commit f01e5b76ca67f728ce5680be252985574924e536
Author: sgrebnov <v-...@microsoft.com>
Date:   2014-09-22T11:19:37Z

    CB-7607 Add xxhdpi and xxxhdpi support to Android Cordova

----


> Add xxhdpi and xxxhdpi support to Android Cordova
> -------------------------------------------------
>
>                 Key: CB-7607
>                 URL: https://issues.apache.org/jira/browse/CB-7607
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android, CordovaLib
>            Reporter: Sergey Grebnov
>            Assignee: Sergey Grebnov
>              Labels: android, assets, cordova-lib, icons, splashscreen
>
> xxhdpi and xxxhdpi support is missing from Android Cordova implementation (icons and splash images)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)