You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@xmlgraphics.apache.org by bu...@apache.org on 2011/01/26 06:54:59 UTC
DO NOT REPLY [Bug 50657] New: [PATCH] ImageIO adds Inch Resolution
Unit, X and Y res, and Rows per Strip
https://issues.apache.org/bugzilla/show_bug.cgi?id=50657
Summary: [PATCH] ImageIO adds Inch Resolution Unit, X and Y
res, and Rows per Strip
Product: XMLGraphicsCommons
Version: Trunk
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P2
Component: ImageWriter
AssignedTo: general@xmlgraphics.apache.org
ReportedBy: joshua.marquart@firstdata.com
Created an attachment (id=26551)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26551)
Patch file for inch res unit and rows per strip changes to xmlgraphicscommons
ImageWriterParams
1) Added more variables to ImageWriterParams to support following changes.
Propose future evaluation to extend class to mime-specific (TIFF, JPEG)
implementations as too many private variables are mime-specific (even prior to
this change).
2) Separated single resolution into X and Y, as unequal values is definitely
possible with TIFF (consider the 196 x 204 standard for faxing); xResolution
becomes container for standard single resolution. setResolution will set both
x and y values equally; getResolution will now return xResolution.
3) Added resolution unit (to allow for inches and none); still defaults to
centimeter.
4) Added rowsPerStrip which at this time may be 1 (default) or pixel height of
current image.
5) Added rowsPerStripOverridden boolean which is evaluated to sets height of
current page as value of rowsPerStrip for TIFF.
ImageIOImageWriter
1) Replaced updateMetadata(IIOMetaData, ImageWriterParams) with
updateMetadata(RenderedImage, IIOMetaData, ImageWriterParams);
Wanted to leave original in for backwards compatibility, but could not
determine a way to do so without breaking. This is the biggest change and will
cause controversy with any classes which extend the current version of
ImageIOImageWriter. As far as I can tell, updateMetadata of ImageIOImageWriter
is only used by Tiff, not by PNG or JPEG and should probably just be moved to
ImageIOTIFFImageWriter.
The reason for the replacement was to allow the height of the current
RenderedImage to be used for RowsPerStrip
2) Altered updateMetadata to account for non-centimeter resolution unit; cm is
still default.
TIFFImageDecoder
1) Added new constants as I could not find a more appropriate class.
ImageIOTIFFImageWriter
1) Applied TIFFImageDecoder constants judiciously. I understand we don't
reference BaselineTIFFTagSet to reduce required libraries on compilation, but
since these classes require imageio anyway, I recommend we reconsider rather
than duplicate code.
2) Added set of Resolution Unit in metadata; calculation performed correctly
for Inch and maintained for Centimeter (default).
2.5) Removed existing code for Resolution Unit - after evaluation, it was
determined this code did absolutely nothing.
3) Added option to override RowsPerStrip with the height of the currently
rendered image; this correctly reduces the size of the metadata, which is
currently immense in comparison, and time to create file.
4) Created utility methods and cleaned up existing.
TIFFImageWriter
1) Accounted for separate X and Y resolutions
2) Accounted for resolution unit (cm (3) is default)
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 50657] [PATCH] ImageIO adds Inch Resolution Unit,
X and Y res, and Rows per Strip
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50657
--- Comment #12 from Joshua Marquart <jo...@firstdata.com> 2011-06-15 16:45:08 UTC ---
In the Fop code I was working from, without my patch, tiffs created would
generate with Centimeter set in the resulting image metadata by default. You
and I discussed it mildly on the list almost a year ago ("Various TIFF
Rendering Questions" - July 2010)
My alterations were an attempt to maintain this default state, while still
adding the Inch and none-specified functionality.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 50657] [PATCH] ImageIO adds Inch Resolution Unit,
X and Y res, and Rows per Strip
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50657
--- Comment #7 from Joshua Marquart <jo...@firstdata.com> 2011-03-03 17:42:23 EST ---
Also, I do believe we should have a variable bits per sample value tag set
(hardened depending on compression) in a future update to the TIFF family along
the lines of this code:
ifd.appendChild(createShortMetadataNode(TIFFImageDecoder.TIFF_BITS_PER_SAMPLE,
"BitsPerSample", "1"));
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 50657] [PATCH] ImageIO adds Inch Resolution Unit,
X and Y res, and Rows per Strip
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50657
--- Comment #2 from Joshua Marquart <jo...@firstdata.com> 2011-01-26 11:55:23 EST ---
Created an attachment (id=26552)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26552)
Replaces earlier attachment, use this instead.
I made a couple mistakes in my initial patch.
Differences in this patch are
ImageWriterParams
1) now uses constant from TIFFImageDecoder for cm instead of arbitrary
hard-coded value 3.
2) replaced unused proposed rowsPerStrip value and new boolean
rowsPerStripOverridden with more appropriately named oneRowPerStrip boolean.
3) revised hasResolution method to check both X and Y, which are both set in
setResolution and their own individual methods.
4) added javadoc comments to many methods that were not commented; my bad.
ImageIOTIFFImageWriter
1) replaced call to isRowsPerStripOverridden with call to NOT isOneRowPerStrip
2) Consolidated identical boolean checks.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 50657] [PATCH] ImageIO adds Inch Resolution Unit,
X and Y res, and Rows per Strip
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50657
--- Comment #10 from Joshua Marquart <jo...@firstdata.com> 2011-06-02 20:25:40 UTC ---
Created attachment 27104
--> https://issues.apache.org/bugzilla/attachment.cgi?id=27104
ResolutionUnit DOT java ENUM attached
ENUM ResolutionUnit.java attached; svn -diff doesn't add completely new files.
Is packaged for org.apache.xmlgraphics.image.writer and should be combined with
the prior patch, Patch 26727
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 50657] [PATCH] ImageIO adds Inch Resolution Unit,
X and Y res, and Rows per Strip
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50657
Jeremias Maerki <je...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
--- Comment #3 from Jeremias Maerki <je...@apache.org> 2011-01-31 15:49:11 EST ---
Thanks for the patch, Joshua. Would you mind doing a couple of changes?
You've added a few constants to TIFFImageDecoder which are only used in the
package o.a.x.image.writer (which is an API package and should not access any
implementation packages). I think it would be better to change these constants
into an enum in the ...image.writer package.
The other one concerns the ImageWriterParams.setOneRowPerStrip(boolean).
Wouldn't it make more sense to actually use an integer here? With the boolean
the only possible values are 1 and <image-height>. With an integer, one could
set 32 rows for a strip, for example. Alternatively, this method could be
renamed to setSingleStrip(boolean) (or something like that) essentially
inverting the meaning of the boolean. My reasoning: setOneRowPerStrip(false)
says "not one row per strip", but setSingleStrip(true) would say "one strip
with <image-height> rows" and setSingleStrip(false) would set the internal
"Integer rowsPerStrip" to 1, allowing to later add a method
setRowsPerStrip(int) if anyone needs that.
Please let me know what you think. I'll later take a deeper look again. Thanks.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 50657] [PATCH] ImageIO adds Inch Resolution Unit,
X and Y res, and Rows per Strip
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50657
--- Comment #6 from Joshua Marquart <jo...@firstdata.com> 2011-03-03 17:40:23 EST ---
Created an attachment (id=26727)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26727)
Patch revision with enum and other changes from comments
Been a little over a month, but the patch has been revised pretty much
according to my comments earlier.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 50657] [PATCH] ImageIO adds Inch Resolution Unit,
X and Y res, and Rows per Strip
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50657
--- Comment #16 from Joshua Marquart <jo...@firstdata.com> 2011-07-26 16:52:55 UTC ---
I missed the comment about single-strip.
You will have to call getWriterParams().setSingleStrip(true) from your renderer
to set that appropriately.
Again, I didn't adjust XSL or xconf.fop, and I'll hold off on alterations to
this Bug to allow this until Jeremias gives the go-ahead. My submitted code
did not conform to the coding standards.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
[Bug 50657] [PATCH] ImageIO adds Inch Resolution Unit, X and Y res,
and Rows per Strip
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50657
Peter Hancock <pe...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |RESOLVED
Resolution|--- |FIXED
--- Comment #21 from Peter Hancock <pe...@gmail.com> ---
Committed 1384277 based upon the contributions of Joshua Marquart and Jeremias
Maerki with minor tweaks.
Note that the unit testing of Tiff metadata was disabled as it required JAI
ImageIO support and this is not currently a dependency of the XGC build
process.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 50657] [PATCH] ImageIO adds Inch Resolution Unit,
X and Y res, and Rows per Strip
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50657
--- Comment #4 from Joshua Marquart <jo...@firstdata.com> 2011-01-31 18:19:02 EST ---
--
Regarding TIFFImageDecoder:
I can certainly create an enum in writer if you like.
I originally placed the value constants in the TIFFImageDecoder class to
persist alongside the name constant they are used with,
TiffImageDecoder.TIFF_RESOLUTION_UNIT. Figured they might be referred-to
elsewhere in the codebase, but have not yet looked.
I do see now that TIFFImageDecoder extends ImageDecoderImpl, and agree this
might not be the best place.
--
Regarding RowsPerStrip:
With ImageWriterParams not being page-specific, as is the case with multi-paged
TIFF files, RowsPerStrip set to image height would need to vary on a per-page
basis and might not be able to be set until the image is rendered, as the value
might not be known.
A different solution that I am going to submit a patch for will have the
following changes to ImageWriterParams:
* VARIABLE rowsPerStrip is an int with standard get/set methods. Defaults to
1.
* METHOD void setSingleStrip(boolean) method - true sets to -1, false sets to
1.
* METHOD boolean isSingleStrip() - convenience returns true if rowsPerStrip ==
-1
--
Regarding BitsPerSample
I believe adding the "BitsPerSample" line might have been a mistake on my part,
and I'll remove it in the upcoming patch revision to this bug.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 50657] [PATCH] ImageIO adds Inch Resolution Unit,
X and Y res, and Rows per Strip
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50657
--- Comment #1 from Joshua Marquart <jo...@firstdata.com> 2011-01-26 01:03:12 EST ---
Referring to the following comment I wrote:
"As far as I can tell, updateMetadata of ImageIOImageWriter
is only used by Tiff, not by PNG or JPEG and should probably just be moved to
ImageIOTIFFImageWriter."
I refer not to the method itself, but to the functionality within the current
updateMetadata method of ImageIOImageWriter. This functionality appears to be
TIFF-specific and
(1) referred to via super in ImageIOTIFFImageWriter,
(2) completely overridden in ImageIOJPEGImageWriter and
(3) ignored(?) by ImageIOPNGImageWriter.
Making updateMetadata abstract may be a viable option.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 50657] [PATCH] ImageIO adds Inch Resolution Unit,
X and Y res, and Rows per Strip
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50657
--- Comment #19 from Joshua Marquart <jo...@firstdata.com> 2012-03-13 21:39:16 UTC ---
As Jeremias has stated recently in an e-mail to the FOP mailing list, "I'm on
hiatus from working on FOP due to various experiences and the direction the
project has taken policy-wise in the last few months," I am uncertain if that
also pertains to the XMLGraphics project and this patch remains up in the air.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 50657] [PATCH] ImageIO adds Inch Resolution Unit,
X and Y res, and Rows per Strip
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50657
--- Comment #5 from Jeremias Maerki <je...@apache.org> 2011-02-01 03:14:08 EST ---
Your suggestion is even better, Joshua. Looking forward to your updated patch.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 50657] [PATCH] ImageIO adds Inch Resolution Unit,
X and Y res, and Rows per Strip
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50657
--- Comment #11 from Jeremias Maerki <je...@apache.org> 2011-06-15 08:02:04 UTC ---
Thanks for supplying the missing file, Joshua. I'm not done with the patch. I'm
currently writing some unit tests to verify that the new code works as
expected. I found that you set the default resolution unit to centimeters
although ImageWriterParams currently uses inches. Later this is converted
internally to units per centimeters. Your new code now mixed up the two,
although the end result in the image file was correct. I'm in the process to
correct that. Please don't post a new patch. I'll fix the problems. I don't
want to restart fixing code style problems (like the tab characters). At this
point I have to interrupt the processing of the patch but I'll continue
shortly. Just to let you know I'm on it as time allows.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 50657] [PATCH] ImageIO adds Inch Resolution Unit,
X and Y res, and Rows per Strip
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50657
--- Comment #9 from Jeremias Maerki <je...@apache.org> 2011-04-22 05:16:17 EDT ---
Sorry for the late response, Joshua. You forgot to include ResolutionUnit in
your patch. Would you please attach that one, too?
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 50657] [PATCH] ImageIO adds Inch Resolution Unit,
X and Y res, and Rows per Strip
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50657
--- Comment #18 from Joshua Marquart <jo...@firstdata.com> 2011-07-28 22:28:52 UTC ---
Jeremias is working on the incorporation; he is doing additional work for it as
well, so I can't comment to that status (see his prior post in this bug). You
may be better off grabbing the code and creating a custom IOWriter to use than
waiting.
The patch in this bug does not add any additional fop.xconf/XSL functionality
to pre-set any values added in this bug.
If you set setSingleStrip(true), it will use the incoming image height
automatically for rowsperstrip; you will not need to set height specifically.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 50657] [PATCH] ImageIO adds Inch Resolution Unit,
X and Y res, and Rows per Strip
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50657
--- Comment #13 from Jeremias Maerki <je...@apache.org> 2011-06-15 19:21:17 UTC ---
I haven't checked TIFF, yet, but with PNG, I stumbled over a bug from 2004 that
has still not been fixed. As you may have seen in the ImageIO JPEG writer,
there is a similar (but different) bug there. More info here:
http://www.tracemodeler.com/articles/aging-bugs-and-setting-dpi-with-java-image-io/
So, it could very well be that it works fine with TIFF but not with other
formats. Still looking for the best way to deal with this.....
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 50657] [PATCH] ImageIO adds Inch Resolution Unit,
X and Y res, and Rows per Strip
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50657
--- Comment #15 from Joshua Marquart <jo...@firstdata.com> 2011-07-26 16:46:56 UTC ---
Hi Dave,
>From what understand, Jeremias is incorporating my patch as time allows.
There were no alterations made to allow new settings to propagate upwards from
xconf.fop.
You will have to call getWriterParams().setResolutionUnit(2) from your renderer
to enforce inches.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 50657] [PATCH] ImageIO adds Inch Resolution Unit,
X and Y res, and Rows per Strip
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50657
Joshua Marquart <jo...@firstdata.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |NEW
--- Comment #8 from Joshua Marquart <jo...@firstdata.com> 2011-03-12 10:26:44 EST ---
Changed back to NEW since info was provided and I didn't change back to NEW.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 50657] [PATCH] ImageIO adds Inch Resolution Unit,
X and Y res, and Rows per Strip
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50657
Glenn Adams <ga...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
CC| |jeremias@apache.org
--- Comment #20 from Glenn Adams <ga...@apache.org> 2012-04-10 19:35:26 UTC ---
(In reply to comment #11)
> Thanks for supplying the missing file, Joshua. I'm not done with the patch.
jeremias, any chance you will be able to commit this (with your changes)?
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 50657] [PATCH] ImageIO adds Inch Resolution Unit,
X and Y res, and Rows per Strip
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50657
--- Comment #17 from Dave Schwartz <Da...@ncr.com> 2011-07-28 15:47:37 UTC ---
The part about the single-strip refers to the fact that the images we are
getting now have a strip per row (strip count = image height) due to the
default rowsperstrip = 1 behaviour.
Similar to requirements for resolutionunit being in inches, I was asking
whether setting rowsperstrip = imageheight (which would be a constant in my
application) could also be done through either the fop.xconf or the XSL itself.
However, since the 'set it in configuration' option is not there for
resolutionunit, requiring a call to set it, then I can also live with having to
make the call to set rowsperstrip.
Thanks.
P.S. Can I assume that Joshua's changes are, or will soon be, incorporated in
the snapshot builds?
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org
DO NOT REPLY [Bug 50657] [PATCH] ImageIO adds Inch Resolution Unit,
X and Y res, and Rows per Strip
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50657
--- Comment #14 from Dave Schwartz <Da...@ncr.com> 2011-07-25 19:54:59 UTC ---
Hi Joshua,
I'm speaking as a prospective user under the FOP framework. I have a
requirement for a project that has some specific needs for TIFF images (header
and content). Using the current FOP and XMLGraphics release, the images are not
conforming to these requirements. One of the repairs (single strip images)
would require decompressing and recompressing which I would rather avoid by
having the image created that way in the first place. I can see a path to be
able to reprocess the TIFF to do that but your patch update would seem to make
that unnecessary. The other requirement I am faced with is for ResolutionUnit
to be 'inches' - I have successfully configured for X/YResolution=200 but it
still presents that as 787402/10000 dots/centimeter.
I understand I could use the options in your patch by calling the appropriate
methods. Since the 'options' I need to set would be the same for every image
generated, is there a way for them to be set through initialization either in
the fop.xconf or XSL file?
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org