[GitHub] [incubator-doris] imay commented on a change in pull request #1560: Do not get file size in Broker openReader() method

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #1560:  Do not get file size in Broker openReader() method
URL: https://github.com/apache/incubator-doris/pull/1560#discussion_r308095991
 
 

 ##########
 File path: be/src/exec/broker_reader.cpp
 ##########
 @@ -112,6 +113,9 @@ Status BrokerReader::open() {
         LOG(WARNING) << ss.str();
         return Status::InternalError(ss.str());
     }
+    // TODO(cmy): The file size is no longer got from openReader() method.
+    // But leave the code here for compatibility.
+    // This will be removed later.
 
 Review comment:
   You overwrite _file_size to 0? This should be a bug

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org