You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/11/25 19:46:21 UTC
[GitHub] [tvm-vta] dsteger opened a new pull request #17: vta: Update VTA to use load_pad_2d in compute
dsteger opened a new pull request #17:
URL: https://github.com/apache/tvm-vta/pull/17
Update compute instruction VTA_MEM_ID_ACC to load using
the load_pad_2d method instead of the load_2d. This resolves
failing unit testing "test_padded_load()". You will also notice
that the indexs are calculated without pragmas to use LUTs over
DSPs. We save 2 DSPs and 1 LUT by not using the pragma.
I've only tested this commit with the ultra96 using unit test ""test_vta_insn.py".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm-vta] tqchen commented on pull request #17: vta: Update VTA to use load_pad_2d in compute
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #17:
URL: https://github.com/apache/tvm-vta/pull/17#issuecomment-738915980
cc @tmoreau89
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm-vta] dsteger commented on pull request #17: vta: Update VTA to use load_pad_2d in compute
Posted by GitBox <gi...@apache.org>.
dsteger commented on pull request #17:
URL: https://github.com/apache/tvm-vta/pull/17#issuecomment-738582984
@tqchen Do you mind taking a look at this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm-vta] tmoreau89 commented on pull request #17: vta: Update VTA to use load_pad_2d in compute
Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on pull request #17:
URL: https://github.com/apache/tvm-vta/pull/17#issuecomment-738954240
Thank you @dsteger, the PR has been merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm-vta] tmoreau89 merged pull request #17: vta: Update VTA to use load_pad_2d in compute
Posted by GitBox <gi...@apache.org>.
tmoreau89 merged pull request #17:
URL: https://github.com/apache/tvm-vta/pull/17
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org