You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Jay D. McHugh (JIRA)" <ji...@apache.org> on 2007/03/30 04:42:25 UTC
[jira] Created: (GERONIMO-3044) Common Libs portlet does not split
the file name correctly on linux
Common Libs portlet does not split the file name correctly on linux
-------------------------------------------------------------------
Key: GERONIMO-3044
URL: https://issues.apache.org/jira/browse/GERONIMO-3044
Project: Geronimo
Issue Type: Bug
Security Level: public (Regular issues)
Components: console
Affects Versions: 1.2, 2.0-M4, 2.0-M5
Reporter: Jay D. McHugh
Priority: Minor
Determining the appropriate path delimiter doesn't work - so every path is split as though it is on windows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-3044) Common Libs portlet does not split
the file name correctly on linux
Posted by "Jay D. McHugh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jay D. McHugh updated GERONIMO-3044:
------------------------------------
Attachment: geronimo-3044.patch
> Common Libs portlet does not split the file name correctly on linux
> -------------------------------------------------------------------
>
> Key: GERONIMO-3044
> URL: https://issues.apache.org/jira/browse/GERONIMO-3044
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 1.2, 2.0-M4, 2.0-M5
> Reporter: Jay D. McHugh
> Priority: Minor
> Attachments: geronimo-3044.patch
>
>
> Determining the appropriate path delimiter doesn't work - so every path is split as though it is on windows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (GERONIMO-3044) Common Libs portlet does not split
the file name correctly on linux
Posted by "Jay D. McHugh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jay D. McHugh resolved GERONIMO-3044.
-------------------------------------
Resolution: Fixed
> Common Libs portlet does not split the file name correctly on linux
> -------------------------------------------------------------------
>
> Key: GERONIMO-3044
> URL: https://issues.apache.org/jira/browse/GERONIMO-3044
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 1.2, 2.0-M4, 2.0-M5
> Reporter: Jay D. McHugh
> Assigned To: Anita Kulshreshtha
> Priority: Minor
> Attachments: geronimo-3044-2.patch, geronimo-3044.patch
>
>
> Determining the appropriate path delimiter doesn't work - so every path is split as though it is on windows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-3044) Common Libs portlet does not split
the file name correctly on linux
Posted by "Jay D. McHugh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jay D. McHugh updated GERONIMO-3044:
------------------------------------
Fix Version/s: 2.0-M5
> Common Libs portlet does not split the file name correctly on linux
> -------------------------------------------------------------------
>
> Key: GERONIMO-3044
> URL: https://issues.apache.org/jira/browse/GERONIMO-3044
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 1.2, 2.0-M4, 2.0-M5
> Reporter: Jay D. McHugh
> Assigned To: Anita Kulshreshtha
> Priority: Minor
> Fix For: 2.0-M5
>
> Attachments: geronimo-3044-2.patch, geronimo-3044.patch
>
>
> Determining the appropriate path delimiter doesn't work - so every path is split as though it is on windows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3044) Common Libs portlet does not
split the file name correctly on linux
Posted by "Anita Kulshreshtha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485883 ]
Anita Kulshreshtha commented on GERONIMO-3044:
----------------------------------------------
Fixed in trunk rev 524588. Thanks Jay!
> Common Libs portlet does not split the file name correctly on linux
> -------------------------------------------------------------------
>
> Key: GERONIMO-3044
> URL: https://issues.apache.org/jira/browse/GERONIMO-3044
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 1.2, 2.0-M4, 2.0-M5
> Reporter: Jay D. McHugh
> Assigned To: Anita Kulshreshtha
> Priority: Minor
> Attachments: geronimo-3044-2.patch, geronimo-3044.patch
>
>
> Determining the appropriate path delimiter doesn't work - so every path is split as though it is on windows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (GERONIMO-3044) Common Libs portlet does not split
the file name correctly on linux
Posted by "Anita Kulshreshtha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anita Kulshreshtha reassigned GERONIMO-3044:
--------------------------------------------
Assignee: Anita Kulshreshtha
> Common Libs portlet does not split the file name correctly on linux
> -------------------------------------------------------------------
>
> Key: GERONIMO-3044
> URL: https://issues.apache.org/jira/browse/GERONIMO-3044
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 1.2, 2.0-M4, 2.0-M5
> Reporter: Jay D. McHugh
> Assigned To: Anita Kulshreshtha
> Priority: Minor
> Attachments: geronimo-3044-2.patch, geronimo-3044.patch
>
>
> Determining the appropriate path delimiter doesn't work - so every path is split as though it is on windows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3044) Common Libs portlet does not
split the file name correctly on linux
Posted by "Anita Kulshreshtha (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485531 ]
Anita Kulshreshtha commented on GERONIMO-3044:
----------------------------------------------
some nit picking...
As you noticed the problem is here if(localFile.indexOf("/") > 0). The correct comparison is if(localFile.indexOf("/") >= 0)
This is because an absolute path name in unix starts with a "/". The patch you supplied works because the absolute pathname in windows do not start with "\" and the comparison (> 0) works.
> Common Libs portlet does not split the file name correctly on linux
> -------------------------------------------------------------------
>
> Key: GERONIMO-3044
> URL: https://issues.apache.org/jira/browse/GERONIMO-3044
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 1.2, 2.0-M4, 2.0-M5
> Reporter: Jay D. McHugh
> Priority: Minor
> Attachments: geronimo-3044.patch
>
>
> Determining the appropriate path delimiter doesn't work - so every path is split as though it is on windows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-3044) Common Libs portlet does not split
the file name correctly on linux
Posted by "Jay D. McHugh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jay D. McHugh updated GERONIMO-3044:
------------------------------------
Attachment: geronimo-3044-2.patch
You're right Anita.
My patch was a bit of overkill that took advantage of the fact that windows paths start with a drive letter. So the location of the first slash will never be 0.
Resubmitting with simple correction of indexOf check.
> Common Libs portlet does not split the file name correctly on linux
> -------------------------------------------------------------------
>
> Key: GERONIMO-3044
> URL: https://issues.apache.org/jira/browse/GERONIMO-3044
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 1.2, 2.0-M4, 2.0-M5
> Reporter: Jay D. McHugh
> Priority: Minor
> Attachments: geronimo-3044-2.patch, geronimo-3044.patch
>
>
> Determining the appropriate path delimiter doesn't work - so every path is split as though it is on windows.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.