You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/03 14:35:25 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #12770: BugFix: Editing a DAG run or Task Instance on UI causes an Error

kaxil commented on a change in pull request #12770:
URL: https://github.com/apache/airflow/pull/12770#discussion_r535278902



##########
File path: airflow/www/forms.py
##########
@@ -158,6 +163,59 @@ def populate_obj(self, item):
             item.conf = json.loads(item.conf)
 
 
+class DagRunEditForm(DynamicForm):

Review comment:
       done in https://github.com/apache/airflow/pull/12770/commits/8c969c85aecc3305e253d65f16b111c3b94a48ab
   
   I don't think we should make conf editable as it should show the conf value passed when the DagRun was created like we do when someone clicks on "Add new DagRun"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org