You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by weifengsmile <gi...@git.apache.org> on 2018/06/04 10:08:14 UTC
[GitHub] incubator-weex pull request #1239: [WEEX-434][iOS] fix the input cannot move...
GitHub user weifengsmile opened a pull request:
https://github.com/apache/incubator-weex/pull/1239
[WEEX-434][iOS] fix the input cannot move down to original position a…
…nd the toolbar of keyboard cover the input component when on bottom
First of all, thank you for your contribution!
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
<!--
How to use github markdown?
### checkable example
- [x] checked
- [ ] not checked
More github Markdown info to see https://guides.github.com/features/mastering-markdown/
-->
CheckList:
**if** *isBugFix* **:**
* [ ] Make sure that you add at least one unit test for the bug which you had fixed.
**elif** *isNewFeature* **:**
* [ ] Update API docs for the component.
* [ ] Update/Add demo to demonstrate new feature.
* [ ] Update test scripts for the feature.
* [ ] Add unit tests for the feature.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/weifengsmile/incubator-weex iOS-bugfix-input-moveup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/1239.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1239
----
commit 6722bd8bfc8d52fc0fcc6e9b3993017efa8d4a31
Author: Sidney Li <si...@...>
Date: 2018-06-04T10:02:28Z
[WEEX-434][iOS] fix the input cannot move down to original position and the toolbar of keyboard cover the input component when on bottom
----
---
[GitHub] incubator-weex issue #1239: [WEEX-434][iOS] fix the input cannot move down t...
Posted by weifengsmile <gi...@git.apache.org>.
Github user weifengsmile commented on the issue:
https://github.com/apache/incubator-weex/pull/1239
iOS 11.1, and the weexSDK version is the latest version in pods. I didn't use the playground app, this is the result from iOS simulator, and there is the same issue in real device.
---
[GitHub] incubator-weex issue #1239: [WEEX-434][iOS] fix the input cannot move down t...
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/1239
<!--
0 failure:
0 warning:
2 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>has no jsfm file changed.</td>
</tr>
<tr>
<td>:book:</td>
<td>jsfm test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
[GitHub] incubator-weex issue #1239: [WEEX-434][iOS] fix the input cannot move down t...
Posted by wqyfavor <gi...@git.apache.org>.
Github user wqyfavor commented on the issue:
https://github.com/apache/incubator-weex/pull/1239
Please provide the page source. I put an edit at the bottom of a page but cannot reproduce this issue. @weifengsmile
---
[GitHub] incubator-weex issue #1239: [WEEX-434][iOS] fix the input cannot move down t...
Posted by wqyfavor <gi...@git.apache.org>.
Github user wqyfavor commented on the issue:
https://github.com/apache/incubator-weex/pull/1239
I cannot reproduce with your source code using playground. What iOS version are you using. Why there is no navigation bar in you picture.
---
[GitHub] incubator-weex issue #1239: [WEEX-434][iOS] fix the input cannot move down t...
Posted by weifengsmile <gi...@git.apache.org>.
Github user weifengsmile commented on the issue:
https://github.com/apache/incubator-weex/pull/1239
```
<template>
<div class="wrapper">
<text class="greeting">The environment is ready!</text>
<input type="text" placeholder="Input Text" class="input" value=""/>
</div>
</template>
<script>
export default {
name: 'App',
data () {
return {
}
}
}
</script>
<style scoped>
.input {
background-color: #ffffff;
margin-top: 300px;
width: 300px;
height: 80px ;
padding: 20px;
color: #000000;
}
.wrapper {
justify-content: center;
align-items: center;
background-color: #888888;
}
.greeting {
text-align: center;
margin-top: 70px;
font-size: 50px;
color: #41B883;
}
</style>
```
It is very simple. You can check the image:
**Issue 1: The WXRootView cannot reset to original position.**
**Issue 2: The keyboards cover a apart of the input component.**
@wqyfavor
---
[GitHub] incubator-weex issue #1239: [WEEX-434][iOS] fix the input cannot move down t...
Posted by wqyfavor <gi...@git.apache.org>.
Github user wqyfavor commented on the issue:
https://github.com/apache/incubator-weex/pull/1239
Please provide your xcode project. I really cannot reproduce. I don't know the differences between playground and your app. Or you may use playground or Taobao app to scan your bundle and to see if this issue can reproduce. @weifengsmile
---
[GitHub] incubator-weex pull request #1239: [WEEX-434][iOS] fix the input cannot move...
Posted by weifengsmile <gi...@git.apache.org>.
Github user weifengsmile closed the pull request at:
https://github.com/apache/incubator-weex/pull/1239
---
[GitHub] incubator-weex issue #1239: [WEEX-434][iOS] fix the input cannot move down t...
Posted by wqyfavor <gi...@git.apache.org>.
Github user wqyfavor commented on the issue:
https://github.com/apache/incubator-weex/pull/1239
@weifengsmile Please close your PR. I created another one and is a little different from yours. https://github.com/apache/incubator-weex/pull/1297
Your fix cannot work in Playground. So I add 20px to offset directly.
---
[GitHub] incubator-weex issue #1239: [WEEX-434][iOS] fix the input cannot move down t...
Posted by weifengsmile <gi...@git.apache.org>.
Github user weifengsmile commented on the issue:
https://github.com/apache/incubator-weex/pull/1239
This is the iOS xcode project:
[ios-issue.zip](https://github.com/apache/incubator-weex/files/2137558/ios-issue.zip)
And this issue can not be reproduced in the playground, it is different from simulator and real device.
You can try it in simulator or real device. @wqyfavor
---
[GitHub] incubator-weex issue #1239: [WEEX-434][iOS] fix the input cannot move down t...
Posted by weifengsmile <gi...@git.apache.org>.
Github user weifengsmile commented on the issue:
https://github.com/apache/incubator-weex/pull/1239
ok, but you should pay attention to the different offset between iOS 10 and iOS 11, and there is also different offset between iPhone X and other iPhones. @wqyfavor
---