You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2016/01/03 14:31:41 UTC

Re: Review Request 41250: Enabled slave get ALLOCATION_SLACK metrics.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41250/
-----------------------------------------------------------

(Updated 一月 3, 2016, 1:31 p.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus Ma.


Bugs: MESOS-4124
    https://issues.apache.org/jira/browse/MESOS-4124


Repository: mesos


Description
-------

Enabled slave get ALLOCATION_SLACK metrics.


Diffs (updated)
-----

  src/slave/metrics.hpp 2c22de521309806d70f9bd124359756b5e4c75b4 
  src/slave/metrics.cpp 1b73121264de3ff6eabc8f620e5b4d5930ba5d43 
  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c 
  src/tests/metrics_tests.cpp f081fb9b68f25c6d6005f195c34253fba8abc146 

Diff: https://reviews.apache.org/r/41250/diff/


Testing (updated)
-------

$ curl "http://192.168.0.107:5051/metrics/snapshot" 2>/dev/null| jq . | grep allocation_slack
  "slave/cpus_allocation_slack_percent": 0,
  "slave/cpus_allocation_slack_total": 3,
  "slave/cpus_allocation_slack_used": 0,
  "slave/disk_allocation_slack_percent": 0,
  "slave/disk_allocation_slack_total": 0,
  "slave/disk_allocation_slack_used": 0,
  "slave/mem_allocation_slack_percent": 0,
  "slave/mem_allocation_slack_total": 1000,
  "slave/mem_allocation_slack_used": 0,


Thanks,

Guangya Liu