You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by "Remko Popma (JIRA)" <ji...@apache.org> on 2016/07/29 09:13:20 UTC
[jira] [Comment Edited] (LOG4J2-1010) Injectable context properties
[ https://issues.apache.org/jira/browse/LOG4J2-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399011#comment-15399011 ]
Remko Popma edited comment on LOG4J2-1010 at 7/29/16 9:12 AM:
--------------------------------------------------------------
About avoiding interaction with ThreadContext, note that [ThreadContextMapFilter|https://logging.apache.org/log4j/2.0/log4j-core/xref/org/apache/logging/log4j/core/filter/ThreadContextMapFilter.html] and [ContextMapLookup|https://logging.apache.org/log4j/2.0/log4j-core/xref/org/apache/logging/log4j/core/lookup/ContextMapLookup.html] get values from ThreadContext, but that is fine since that is the "contract" of these classes, that is what they are defined to do. I don't think these need to be changed. If we support additional sources of Context data, we can add filters and lookups for them.
For {{DynamicThresholdFilter}} I think it makes sense to go through the ContextDataInjector rather than querying the ThreadContext.
was (Author: remkop@yahoo.com):
About avoiding interaction with ThreadContext, note that [ThreadContextMapFilter|https://logging.apache.org/log4j/2.0/log4j-core/xref/org/apache/logging/log4j/core/filter/ThreadContextMapFilter.html] and [ContextMapLookup|https://logging.apache.org/log4j/2.0/log4j-core/xref/org/apache/logging/log4j/core/lookup/ContextMapLookup.html] get values from ThreadContext, but that is fine since that is the "contract" of these classes, that is what they are defined to do. I don't think these need to be changed.
For {{DynamicThresholdFilter}} I think it makes sense to go through the ContextDataInjector rather than querying the ThreadContext.
> Injectable context properties
> -----------------------------
>
> Key: LOG4J2-1010
> URL: https://issues.apache.org/jira/browse/LOG4J2-1010
> Project: Log4j 2
> Issue Type: Improvement
> Components: Core
> Affects Versions: 2.2
> Reporter: Mikael Ståldal
> Assignee: Remko Popma
> Fix For: 2.7
>
> Attachments: properties.patch
>
>
> It would be useful to have a way to inject context properties into a {{LogEvent}}, as an alternative to {{ThreadContext}}.
> In an asynchronous environment, using ThreadContext as currently implemented is not so useful since JVM threads might not be coupled to the logical flow of the application.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org