[GitHub] [iceberg] Fokko commented on a diff in pull request #8532: Python: Add checks after building the wheels

["Fokko (via GitHub)" <gi...@apache.org>]

Fokko commented on code in PR #8532:
URL: https://github.com/apache/iceberg/pull/8532#discussion_r1320558971


##########
python/build-module.py:
##########
@@ -40,28 +40,20 @@ def build_cython_extensions() -> None:
         extra_compile_args = [
             "-O3",
         ]
-    # Relative to project root directory
-    include_dirs = {
-        "pyiceberg/",
-    }
 
-    extensions = [

Review Comment:
   I've cleaned this a bit up because we don't rely on other c-bindings, so the included dirs are not required. This reduces the number of paths that we pass in (and that might be different on other platforms).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org