You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2015/07/06 14:31:15 UTC
Review Request 36198: LENS-647 : Fix multi fact query with expressions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36198/
-----------------------------------------------------------
Review request for lens and Rajat Khandelwal.
Bugs: LENS-647
https://issues.apache.org/jira/browse/LENS-647
Repository: lens
Description
-------
- Fixes issues with multi fact queries when expressions are queried.
- Also fixes candidate prune causes when a fact set is removed and its underlying facts are removed.
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 63d2508
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 75d5581
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 57c075c
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java b2997dd
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 53996c4
Diff: https://reviews.apache.org/r/36198/diff/
Testing
-------
Added unit tests which fail without the fix.
All cube tests pass. Will update full test run.
Thanks,
Amareshwari Sriramadasu
Re: Review Request 36198: LENS-647 : Fix multi fact query with
expressions
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36198/#review91275
-----------------------------------------------------------
Ship it!
Ship It!
- Rajat Khandelwal
On July 7, 2015, 11:25 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36198/
> -----------------------------------------------------------
>
> (Updated July 7, 2015, 11:25 a.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Bugs: LENS-647
> https://issues.apache.org/jira/browse/LENS-647
>
>
> Repository: lens
>
>
> Description
> -------
>
> - Fixes issues with multi fact queries when expressions are queried.
> - Also fixes candidate prune causes when a fact set is removed and its underlying facts are removed.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 63d2508
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 75d5581
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 57c075c
> lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java b2997dd
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 53996c4
>
> Diff: https://reviews.apache.org/r/36198/diff/
>
>
> Testing
> -------
>
> Added unit tests which fail without the fix.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.988s]
> [INFO] Lens .............................................. SUCCESS [2.853s]
> [INFO] Lens API .......................................... SUCCESS [19.154s]
> [INFO] Lens API for server and extensions ................ SUCCESS [18.586s]
> [INFO] Lens Cube ......................................... SUCCESS [3:33.084s]
> [INFO] Lens DB storage ................................... SUCCESS [18.436s]
> [INFO] Lens Query Library ................................ SUCCESS [15.990s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:44.208s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [34.605s]
> [INFO] Lens Server ....................................... SUCCESS [5:22.031s]
> [INFO] Lens client ....................................... SUCCESS [35.660s]
> [INFO] Lens CLI .......................................... SUCCESS [2:34.182s]
> [INFO] Lens Examples ..................................... SUCCESS [8.952s]
> [INFO] Lens Distribution ................................. SUCCESS [8.051s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:15.477s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [3.575s]
> [INFO] Lens Regression ................................... SUCCESS [24.867s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:42.532s
> [INFO] Finished at: Tue Jul 07 05:34:37 UTC 2015
> [INFO] Final Memory: 206M/2652M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 36198: LENS-647 : Fix multi fact query with
expressions
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On July 10, 2015, 6:32 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java, line 44
> > <https://reviews.apache.org/r/36198/diff/2/?file=1000903#file1000903line44>
> >
> > Can we have one test case covering this cause?
TestBaseCubeQueries.testColumnErrors has been updated to test this
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36198/#review91273
-----------------------------------------------------------
On July 7, 2015, 5:55 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36198/
> -----------------------------------------------------------
>
> (Updated July 7, 2015, 5:55 a.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Bugs: LENS-647
> https://issues.apache.org/jira/browse/LENS-647
>
>
> Repository: lens
>
>
> Description
> -------
>
> - Fixes issues with multi fact queries when expressions are queried.
> - Also fixes candidate prune causes when a fact set is removed and its underlying facts are removed.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 63d2508
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 75d5581
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 57c075c
> lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java b2997dd
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 53996c4
>
> Diff: https://reviews.apache.org/r/36198/diff/
>
>
> Testing
> -------
>
> Added unit tests which fail without the fix.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.988s]
> [INFO] Lens .............................................. SUCCESS [2.853s]
> [INFO] Lens API .......................................... SUCCESS [19.154s]
> [INFO] Lens API for server and extensions ................ SUCCESS [18.586s]
> [INFO] Lens Cube ......................................... SUCCESS [3:33.084s]
> [INFO] Lens DB storage ................................... SUCCESS [18.436s]
> [INFO] Lens Query Library ................................ SUCCESS [15.990s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:44.208s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [34.605s]
> [INFO] Lens Server ....................................... SUCCESS [5:22.031s]
> [INFO] Lens client ....................................... SUCCESS [35.660s]
> [INFO] Lens CLI .......................................... SUCCESS [2:34.182s]
> [INFO] Lens Examples ..................................... SUCCESS [8.952s]
> [INFO] Lens Distribution ................................. SUCCESS [8.051s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:15.477s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [3.575s]
> [INFO] Lens Regression ................................... SUCCESS [24.867s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:42.532s
> [INFO] Finished at: Tue Jul 07 05:34:37 UTC 2015
> [INFO] Final Memory: 206M/2652M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 36198: LENS-647 : Fix multi fact query with
expressions
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36198/#review91273
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java (line 43)
<https://reviews.apache.org/r/36198/#comment144565>
Can we have one test case covering this cause?
- Rajat Khandelwal
On July 7, 2015, 11:25 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36198/
> -----------------------------------------------------------
>
> (Updated July 7, 2015, 11:25 a.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Bugs: LENS-647
> https://issues.apache.org/jira/browse/LENS-647
>
>
> Repository: lens
>
>
> Description
> -------
>
> - Fixes issues with multi fact queries when expressions are queried.
> - Also fixes candidate prune causes when a fact set is removed and its underlying facts are removed.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 63d2508
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 75d5581
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 57c075c
> lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java b2997dd
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 53996c4
>
> Diff: https://reviews.apache.org/r/36198/diff/
>
>
> Testing
> -------
>
> Added unit tests which fail without the fix.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.988s]
> [INFO] Lens .............................................. SUCCESS [2.853s]
> [INFO] Lens API .......................................... SUCCESS [19.154s]
> [INFO] Lens API for server and extensions ................ SUCCESS [18.586s]
> [INFO] Lens Cube ......................................... SUCCESS [3:33.084s]
> [INFO] Lens DB storage ................................... SUCCESS [18.436s]
> [INFO] Lens Query Library ................................ SUCCESS [15.990s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:44.208s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [34.605s]
> [INFO] Lens Server ....................................... SUCCESS [5:22.031s]
> [INFO] Lens client ....................................... SUCCESS [35.660s]
> [INFO] Lens CLI .......................................... SUCCESS [2:34.182s]
> [INFO] Lens Examples ..................................... SUCCESS [8.952s]
> [INFO] Lens Distribution ................................. SUCCESS [8.051s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:15.477s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [3.575s]
> [INFO] Lens Regression ................................... SUCCESS [24.867s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:42.532s
> [INFO] Finished at: Tue Jul 07 05:34:37 UTC 2015
> [INFO] Final Memory: 206M/2652M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 36198: LENS-647 : Fix multi fact query with
expressions
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36198/
-----------------------------------------------------------
(Updated July 7, 2015, 5:55 a.m.)
Review request for lens and Rajat Khandelwal.
Changes
-------
Fix intermittent failure in TestBaseCubeQueries.testColumnErrors
Bugs: LENS-647
https://issues.apache.org/jira/browse/LENS-647
Repository: lens
Description
-------
- Fixes issues with multi fact queries when expressions are queried.
- Also fixes candidate prune causes when a fact set is removed and its underlying facts are removed.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 63d2508
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java 75d5581
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 57c075c
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java b2997dd
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 53996c4
Diff: https://reviews.apache.org/r/36198/diff/
Testing (updated)
-------
Added unit tests which fail without the fix.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.988s]
[INFO] Lens .............................................. SUCCESS [2.853s]
[INFO] Lens API .......................................... SUCCESS [19.154s]
[INFO] Lens API for server and extensions ................ SUCCESS [18.586s]
[INFO] Lens Cube ......................................... SUCCESS [3:33.084s]
[INFO] Lens DB storage ................................... SUCCESS [18.436s]
[INFO] Lens Query Library ................................ SUCCESS [15.990s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:44.208s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [34.605s]
[INFO] Lens Server ....................................... SUCCESS [5:22.031s]
[INFO] Lens client ....................................... SUCCESS [35.660s]
[INFO] Lens CLI .......................................... SUCCESS [2:34.182s]
[INFO] Lens Examples ..................................... SUCCESS [8.952s]
[INFO] Lens Distribution ................................. SUCCESS [8.051s]
[INFO] Lens ML Lib ....................................... SUCCESS [2:15.477s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [3.575s]
[INFO] Lens Regression ................................... SUCCESS [24.867s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:42.532s
[INFO] Finished at: Tue Jul 07 05:34:37 UTC 2015
[INFO] Final Memory: 206M/2652M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu