You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/01 00:13:33 UTC
[GitHub] [airflow] tigerjz32 opened a new pull request #6985: [AIRFLOW-6381]
Remove styling based on DAG id from DAGs page
tigerjz32 opened a new pull request #6985: [AIRFLOW-6381] Remove styling based on DAG id from DAGs page
URL: https://github.com/apache/airflow/pull/6985
- [ ] Description above provides context of the change
- [ ] Commit message contains [\[AIRFLOW-XXXX\]](https://issues.apache.org/jira/browse/AIRFLOW-XXXX) or `[AIRFLOW-XXXX]` for document-only changes
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] boring-cyborg[bot] commented on issue #6985:
[AIRFLOW-6381] Remove styling based on DAG id from DAGs page
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #6985: [AIRFLOW-6381] Remove styling based on DAG id from DAGs page
URL: https://github.com/apache/airflow/pull/6985#issuecomment-571409212
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #6985: [AIRFLOW-6381] Remove
styling based on DAG id from DAGs page
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #6985: [AIRFLOW-6381] Remove styling based on DAG id from DAGs page
URL: https://github.com/apache/airflow/pull/6985#issuecomment-570741250
Something is wrong with this change. It contains a huge amount of commit. Can you fix it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil merged pull request #6985: [AIRFLOW-6381] Remove
styling based on DAG id from DAGs page
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #6985: [AIRFLOW-6381] Remove styling based on DAG id from DAGs page
URL: https://github.com/apache/airflow/pull/6985
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #6985:
[AIRFLOW-6381] Remove styling based on DAG id from DAGs page
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #6985: [AIRFLOW-6381] Remove styling based on DAG id from DAGs page
URL: https://github.com/apache/airflow/pull/6985#discussion_r363566077
##########
File path: airflow/www/templates/airflow/dags.html
##########
@@ -88,7 +88,7 @@ <h2>DAGs</h2>
<!-- Column 4: Dag Schedule -->
<td>
- <a class="label label-default schedule {{ dag.dag_id }}" href="{{ url_for('DagRunModelView.list') }}?_flt_3_dag_id={{ dag.dag_id }}">
Review comment:
I've seen it before, but I believed it had a purpose. :-D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil closed pull request #6985: [AIRFLOW-6381] Remove
styling based on DAG id from DAGs page
Posted by GitBox <gi...@apache.org>.
kaxil closed pull request #6985: [AIRFLOW-6381] Remove styling based on DAG id from DAGs page
URL: https://github.com/apache/airflow/pull/6985
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] tigerjz32 opened a new pull request #6985: [AIRFLOW-6381]
Remove styling based on DAG id from DAGs page
Posted by GitBox <gi...@apache.org>.
tigerjz32 opened a new pull request #6985: [AIRFLOW-6381] Remove styling based on DAG id from DAGs page
URL: https://github.com/apache/airflow/pull/6985
- [ ] Description above provides context of the change
- [ ] Commit message contains [\[AIRFLOW-XXXX\]](https://issues.apache.org/jira/browse/AIRFLOW-XXXX) or `[AIRFLOW-XXXX]` for document-only changes
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #6985:
[AIRFLOW-6381] Remove styling based on DAG id from DAGs page
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #6985: [AIRFLOW-6381] Remove styling based on DAG id from DAGs page
URL: https://github.com/apache/airflow/pull/6985#discussion_r363527271
##########
File path: airflow/www/templates/airflow/dags.html
##########
@@ -88,7 +88,7 @@ <h2>DAGs</h2>
<!-- Column 4: Dag Schedule -->
<td>
- <a class="label label-default schedule {{ dag.dag_id }}" href="{{ url_for('DagRunModelView.list') }}?_flt_3_dag_id={{ dag.dag_id }}">
Review comment:
Don't think we do as dag_id can be literally anything!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #6985: [AIRFLOW-6381] Remove
styling based on DAG id from DAGs page
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #6985: [AIRFLOW-6381] Remove styling based on DAG id from DAGs page
URL: https://github.com/apache/airflow/pull/6985#issuecomment-571357016
Waiting for the CI to pass before I merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #6985: [AIRFLOW-6381] Remove
styling based on DAG id from DAGs page
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #6985: [AIRFLOW-6381] Remove styling based on DAG id from DAGs page
URL: https://github.com/apache/airflow/pull/6985#issuecomment-571356298
I have updated the base so should be fine now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #6985:
[AIRFLOW-6381] Remove styling based on DAG id from DAGs page
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #6985: [AIRFLOW-6381] Remove styling based on DAG id from DAGs page
URL: https://github.com/apache/airflow/pull/6985#discussion_r363526629
##########
File path: airflow/www/templates/airflow/dags.html
##########
@@ -88,7 +88,7 @@ <h2>DAGs</h2>
<!-- Column 4: Dag Schedule -->
<td>
- <a class="label label-default schedule {{ dag.dag_id }}" href="{{ url_for('DagRunModelView.list') }}?_flt_3_dag_id={{ dag.dag_id }}">
Review comment:
@mik-laj Do you know if we have custom CSS somewhere based on DAG ID
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] tigerjz32 commented on issue #6985: [AIRFLOW-6381] Remove
styling based on DAG id from DAGs page
Posted by GitBox <gi...@apache.org>.
tigerjz32 commented on issue #6985: [AIRFLOW-6381] Remove styling based on DAG id from DAGs page
URL: https://github.com/apache/airflow/pull/6985#issuecomment-571360463
Thank you @kaxil!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services