[GitHub] [incubator-echarts] pissang commented on a change in pull request #12266: Fix#12164 Erroneous Behavior when displaying a line chart with multiple data pushes before updating chart data while zoomed in

[GitBox <gi...@apache.org>]

pissang commented on a change in pull request #12266: Fix#12164  Erroneous Behavior when displaying a line chart with multiple data pushes before updating chart data while zoomed in
URL: https://github.com/apache/incubator-echarts/pull/12266#discussion_r390926226
 
 

 ##########
 File path: src/chart/line/lineAnimationDiff.js
 ##########
 @@ -166,6 +166,7 @@ export default function (
 
     // Diff result may be crossed if all items are changed
     // Sort by data index
+    rawIndices =  Array.from(new Set(rawIndices));
 
 Review comment:
   Please don't use `Array.from` and `Set` because it's not supported in IE. See https://www.echartsjs.com/zh/coding-standard.html

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org