[GitHub] [sling-org-apache-sling-committer-cli] raducotescu commented on a change in pull request #6: SLING-8864 - Report authentication errors immediately without looking at the response's body

[GitBox <gi...@apache.org>]

raducotescu commented on a change in pull request #6: SLING-8864 - Report authentication errors immediately without looking at the response's body
URL: https://github.com/apache/sling-org-apache-sling-committer-cli/pull/6#discussion_r356489984
 
 

 ##########
 File path: src/main/java/org/apache/sling/cli/impl/http/HttpClientFactory.java
 ##########
 @@ -61,9 +67,18 @@ protected void activate(ComponentContext ctx) {
     }
 
     public CloseableHttpClient newClient() {
-        
+        final AtomicReference<String> url = new AtomicReference<>();
 
 Review comment:
   I usually use this pattern when having to deal with outside context in a lambda. We could also switch to your proposal, if you think it makes more sense.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services