[GitHub] [kafka] vvcephei commented on pull request #13021: KAFKA-14468: Implement CommitRequestManager to manage the commit and autocommit requests

[GitBox <gi...@apache.org>]

vvcephei commented on PR #13021:
URL: https://github.com/apache/kafka/pull/13021#issuecomment-1367452673

   Thanks @philipnee !
   
   I just made a quick pass. I'm sorry; I haven't been keeping up with the progress of your project, so I'm a little hazy on the details.
   
   It looks like the new CommitRequestManager is a component that lives in the background part of the system, basically to help the background thread keep track of commit requests that have been/need to be sent to the network?
   
   I think that makes sense, but in that case, it is mildly surprising to see autocommit living where it lives. I initially would have expected it to originate from the foreground, but on second though, maybe it's because the background thread runs on a reliable timer? The caller is required to call `poll` on a regular basis, but maybe it's not frequent enough for your purposes?
   
   It would be good to understand the general principle for the division of responsibilities between the foreground and background. Do you have this documented somewhere that we can use for a north star?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org