[jira] [Commented] (MINIFICPP-1833) Integrate additional clang-tidy checks in CI

["Gábor Gyimesi (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MINIFICPP-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536500#comment-17536500 ] 

Gábor Gyimesi commented on MINIFICPP-1833:
------------------------------------------

A list of possible candidate to add provided by [~szaszm]:
-*
cppcoreguidelines-interfaces-global-init
cppcoreguidelines-narrowing-conversions
cppcoreguidelines-pro-type-member-init
cppcoreguidelines-pro-type-static-cast-downcast
cppcoreguidelines-slicing
google-default-arguments
google-explicit-constructor
google-runtime-operator
hicpp-exception-baseclass
hicpp-multiway-paths-covered
misc-misplaced-const
misc-new-delete-overloads
misc-no-recursion
misc-non-copyable-objects
misc-throw-by-value-catch-by-reference
misc-unconventional-assign-operator
misc-uniqueptr-reset-release
modernize-avoid-bind
modernize-concat-nested-namespaces
modernize-deprecated-headers
modernize-deprecated-ios-base-aliases
modernize-loop-convert
modernize-make-shared
modernize-make-unique
modernize-pass-by-value
modernize-raw-string-literal
modernize-redundant-void-arg
modernize-replace-auto-ptr
modernize-replace-disallow-copy-and-assign-macro
modernize-replace-random-shuffle
modernize-return-braced-init-list
modernize-shrink-to-fit
modernize-unary-static-assert
modernize-use-auto
modernize-use-bool-literals
modernize-use-emplace
modernize-use-equals-default
modernize-use-equals-delete
modernize-use-nodiscard
modernize-use-noexcept
modernize-use-nullptr
modernize-use-override
modernize-use-transparent-functors
modernize-use-uncaught-exceptions
mpi-buffer-deref
mpi-type-mismatch
openmp-use-default-none
performance-faster-string-find
performance-for-range-copy
performance-implicit-conversion-in-loop
performance-inefficient-algorithm
performance-inefficient-string-concatenation
performance-inefficient-vector-operation
performance-move-const-arg
performance-move-constructor-init
performance-no-automatic-move
performance-noexcept-move-constructor
performance-trivially-destructible
performance-type-promotion-in-math-fn
performance-unnecessary-copy-initialization
performance-unnecessary-value-param
portability-simd-intrinsics
readability-avoid-const-params-in-decls
readability-const-return-type
readability-container-size-empty
readability-convert-member-functions-to-static
readability-delete-null-pointer
readability-deleted-default
readability-inconsistent-declaration-parameter-name
readability-make-member-function-const
readability-misleading-indentation
readability-misplaced-array-index
readability-non-const-parameter
readability-redundant-control-flow
readability-redundant-declaration
readability-redundant-function-ptr-dereference
readability-redundant-smartptr-get
readability-redundant-string-cstr
readability-redundant-string-init
readability-simplify-subscript-expr
readability-static-accessed-through-instance
readability-static-definition-in-anonymous-namespace
readability-string-compare
readability-uniqueptr-delete-release
readability-use-anyofallof

> Integrate additional clang-tidy checks in CI
> --------------------------------------------
>
>                 Key: MINIFICPP-1833
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-1833
>             Project: Apache NiFi MiNiFi C++
>          Issue Type: New Feature
>            Reporter: Gábor Gyimesi
>            Priority: Minor
>              Labels: MiNiFi-CPP-Hygiene
>
> Additional checks of clang-tidy should be added by evaluating which checks should be enabled in our project and fixing the failures where possible then integrating it to the CI checks. If some checks should be enabled, but it would take way too much effort to fix them at once, they should be enabled in the CI and should be fixed when the problematic file is changed.
> Checks that need to be enabled:
>  * hicpp*
>  * misc*
>  * modernize*
>  * readability*
>  * cppcoreguidelines*
>  * performance*
>  * google*
> Note: This ticket can be broken down to multiple tickets if integrating the additional checks would be too much effort at once



--
This message was sent by Atlassian Jira
(v8.20.7#820007)