[GitHub] [arrow-datafusion-python] andygrove commented on a diff in pull request #320: Prepare for 22.0.0 release

["andygrove (via GitHub)" <gi...@apache.org>]

andygrove commented on code in PR #320:
URL: https://github.com/apache/arrow-datafusion-python/pull/320#discussion_r1162146260


##########
datafusion/tests/test_context.py:
##########
@@ -282,10 +282,11 @@ def test_dataset_filter_nested_data(ctx):
 
     # This filter will not be pushed down to DatasetExec since it
     # isn't supported
-    df = df.select(
+    df = df.filter(column("nested_data")["b"] > literal(5))\

Review Comment:
   Move the filter before the select due to https://github.com/apache/arrow-datafusion/issues/5949



##########
datafusion/tests/test_dataframe.py:
##########
@@ -84,10 +84,11 @@ def test_select_columns(df):
 
 
 def test_filter(df):
-    df = df.select(
+    df = df.filter(column("a") > literal(2))\

Review Comment:
   Move the filter before the select due to https://github.com/apache/arrow-datafusion/issues/5949



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org