You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/05/14 08:31:56 UTC

[GitHub] [pulsar] BewareMyPower commented on a change in pull request #10586: Fix NPE when ACK grouping tracker checks duplicated message id

BewareMyPower commented on a change in pull request #10586:
URL: https://github.com/apache/pulsar/pull/10586#discussion_r632372675



##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageIdImpl.java
##########
@@ -210,7 +210,8 @@ public int compareTo(MessageId o) {
         } else if (o instanceof TopicMessageIdImpl) {
             return compareTo(((TopicMessageIdImpl) o).getInnerMessageId());
         } else {
-            throw new UnsupportedOperationException("Unknown MessageId type: " + o.getClass().getName());
+            final String typeName = (o != null) ? o.getClass().getName() : "null";

Review comment:
       I agree.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org