You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2018/03/01 13:57:12 UTC
Re: Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk
resources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65838/#review198447
-----------------------------------------------------------
Please add this to `v1/resources.cpp` as well.
- Jan Schlicht
On Feb. 28, 2018, 5:13 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65838/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2018, 5:13 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated validation of 'RAW' and 'BLOCK' disk resources.
>
>
> Diffs
> -----
>
> src/common/resources.cpp a0c29246b3e3b377aabd0eb00ba16aa6bbd804e3
>
>
> Diff: https://reviews.apache.org/r/65838/diff/1/
>
>
> Testing
> -------
>
> `make check`
> `sudo make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk
resources.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On March 1, 2018, 2:57 p.m., Jan Schlicht wrote:
> > Please add this to `v1/resources.cpp` as well.
Done.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65838/#review198447
-----------------------------------------------------------
On March 2, 2018, 11:46 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65838/
> -----------------------------------------------------------
>
> (Updated March 2, 2018, 11:46 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated validation of 'RAW' and 'BLOCK' disk resources.
>
>
> Diffs
> -----
>
> src/common/resources.cpp 8cb74176aae969727a4c3d91c37b05de3463da33
> src/v1/resources.cpp 7fc6cd803982ea3c28bf0983d868f14fc6355cc9
>
>
> Diff: https://reviews.apache.org/r/65838/diff/2/
>
>
> Testing
> -------
>
> `make check`
> `sudo make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>