You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2016/02/07 14:57:51 UTC
Review Request 43308: Added systemd life-extension option to container
logrotate module.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43308/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Jie Yu.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/slave/container_loggers/lib_logrotate.cpp 01a3ff031b70366443214e2895803cd4b2606ad8
Diff: https://reviews.apache.org/r/43308/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 43308: Added systemd life-extension option to
container logrotate module.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43308/#review118278
-----------------------------------------------------------
Ship it!
LGTM!
- Joseph Wu
On Feb. 7, 2016, 5:57 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43308/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2016, 5:57 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/container_loggers/lib_logrotate.cpp 01a3ff031b70366443214e2895803cd4b2606ad8
>
> Diff: https://reviews.apache.org/r/43308/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 43308: Added systemd life-extension option to
container logrotate module.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43308/#review118572
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/container_loggers/lib_logrotate.cpp (line 132)
<https://reviews.apache.org/r/43308/#comment179844>
`&` here as well please?
- Benjamin Hindman
On Feb. 9, 2016, 7:14 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43308/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 7:14 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added systemd life-extension option to container logrotate module.
>
>
> Diffs
> -----
>
> src/slave/container_loggers/lib_logrotate.cpp 01a3ff031b70366443214e2895803cd4b2606ad8
>
> Diff: https://reviews.apache.org/r/43308/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 43308: Added systemd life-extension option to
container logrotate module.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43308/
-----------------------------------------------------------
(Updated Feb. 10, 2016, 4:53 p.m.)
Review request for mesos, Benjamin Hindman and Jie Yu.
Bugs: MESOS-4640
https://issues.apache.org/jira/browse/MESOS-4640
Repository: mesos
Description
-------
Added systemd life-extension option to container logrotate module.
Diffs (updated)
-----
src/slave/container_loggers/lib_logrotate.cpp 01a3ff031b70366443214e2895803cd4b2606ad8
Diff: https://reviews.apache.org/r/43308/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 43308: Added systemd life-extension option to
container logrotate module.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43308/
-----------------------------------------------------------
(Updated Feb. 9, 2016, 7:14 p.m.)
Review request for mesos, Benjamin Hindman and Jie Yu.
Repository: mesos
Description (updated)
-------
Added systemd life-extension option to container logrotate module.
Diffs (updated)
-----
src/slave/container_loggers/lib_logrotate.cpp 01a3ff031b70366443214e2895803cd4b2606ad8
Diff: https://reviews.apache.org/r/43308/diff/
Testing
-------
Thanks,
Joris Van Remoortere