[jira] [Commented] (GEODE-5135) Refactor the static method AbstractRegionMap.createCBEvent

["Sayyed Ali Kiaian Mousavy (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-5135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773141#comment-16773141 ] 

Sayyed Ali Kiaian Mousavy commented on GEODE-5135:
--------------------------------------------------

I'm a beginner contributor and a CS student at KTH. Can I start working on this issue for coding practice?

> Refactor the static method AbstractRegionMap.createCBEvent
> ----------------------------------------------------------
>
>                 Key: GEODE-5135
>                 URL: https://issues.apache.org/jira/browse/GEODE-5135
>             Project: Geode
>          Issue Type: Improvement
>          Components: transactions
>            Reporter: Darrel Schneider
>            Priority: Major
>              Labels: AbstractRegionMap
>
> AbstractRegionMap.createCBEvent would make more sense as a factory method on EntryEventImpl. Note that ProxyRegionMap currently calls static methods on AbstractRegionMap.
> Since ProxyRegionMap and AbstractRegionMap both implement the RegionMap interface it would be better to either have a common ancestor class for both these classes that contains this common code they share or move this code to methods on the RegionMap interface. It would be nice if ProxyRegionMap did not depend on anything in AbstractRegionMap.
> One idea would be to rename AbstractRegionMap to StorageRegionMap and then have the common ancestor class that both ProxyRegionMap and StorageRegionMap extend by named AbstractRegionMap.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)