You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/05/18 18:08:02 UTC

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #4518: Add service category feature to TO and TP

rob05c commented on a change in pull request #4518:
URL: https://github.com/apache/trafficcontrol/pull/4518#discussion_r426806102



##########
File path: lib/go-atscfg/headerrewritedotconfig.go
##########
@@ -32,6 +34,8 @@ import (
 const HeaderRewritePrefix = "hdr_rw_"
 const ContentTypeHeaderRewriteDotConfig = ContentTypeTextASCII
 
+const ServiceCategoryHeader = "X-CDN-SVC"

Review comment:
       Would you mind changing this to `CDN-SVC`? The IETF has asked that people stop using `X-` for nonstandard headers, because they often become widespread, and  then it's difficult to make a new standard without the `X-`. Where if people don't  use `X-` to begin with, it's easy to make the header a standard when it becomes widespread.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org